Skip to content

fix(tailwind): preserve literal black and white - #2253

Merged
kotAPI merged 1 commit into
mainfrom
automation/weekly-2026-10-16
Oct 16, 2026
Merged

kotAPI merged 1 commit into
mainfrom
automation/weekly-2026-10-16

Conversation

@kotAPI

@kotAPI kotAPI commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • keep Tailwind black and white utilities literal across appearances
  • add generated-preset coverage
  • add a patch changeset

Checks

  • npm test -- --runInBand
  • npm run lint
  • npm run build:rollup
  • npm run validate:changesets

Summary by CodeRabbit

  • Bug Fixes
    • Tailwind’s black and white utilities now remain literal colors across appearances instead of changing with appearance-dependent theme tokens.

@changeset-bot

changeset-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1cd915a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@radui/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 08ce7c06-c388-4e2b-bd89-2890cafa423c
📥 Commits

Reviewing files that changed from the base of the PR and between b6ec9ca and 1cd915a.

📒 Files selected for processing: 4
  • .changeset/tender-swans-fix.md
  • scripts/generate-tailwind-preset.test.ts
  • scripts/generate-tailwind-preset.ts
  • styles/tailwind-presets/default.css
💤 Files with no reviewable changes: 1
  • styles/tailwind-presets/default.css

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The Tailwind preset generator now excludes black and white from generated color variables. The default preset output and a new test reflect this change. A patch changeset records the change.

Changes: Tailwind color preset

Layer / File(s) Summary
Exclude literal colors from preset output
scripts/generate-tailwind-preset.ts, styles/tailwind-presets/default.css, scripts/generate-tailwind-preset.test.ts, .changeset/tender-swans-fix.md
The generator skips black and white color entries. The default preset no longer maps these names to Rad UI color properties. A test checks that generated output omits both variables, and a patch changeset records the change.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 1cd91

The change removes appearance-dependent overrides while preserving Tailwind’s literal black and white utilities. No merge-blocking behavior is indicated.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: preserving Tailwind's literal black and white utilities.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage

This report compares the PR with the base branch. "Δ" shows how the PR affects each metric.

Metric PR Δ
Statements 85.71% +0.00%
Branches 71.07% +0.00%
Functions 77.87% +0.00%
Lines 87.57% +0.00%

Coverage improved or stayed the same. Great job!

Run npm run coverage:ci locally for detailed reports and target untested areas to raise these numbers.

@kotAPI
kotAPI merged commit 519eaa2 into main Oct 16, 2026
14 of 15 checks passed
@kotAPI
kotAPI deleted the automation/weekly-2026-10-16 branch October 16, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant