FROMLIST: Enable ICE for UFS on Hamoa IoT EVK

[arakshit011]

This series enables the Inline Crypto Engine (ICE) hardware for UFS
storage on the Qualcomm X1E80100 (Hamoa IoT EVK) platform.

The ICE hardware provides AES-256-XTS inline encryption/decryption for
UFS storage, offloading cryptographic operations from the CPU. The
hardware version on this platform is ICE v4.0.1 with HWKM v2 support.

Validation:

Probe successfully
Standard key work well
Patch 1 adds the new compatible string to the DT binding documentation.
Patch 2 adds the ICE device node to the Hamoa DTSI.

Link: https://lore.kernel.org/all/20260722-devtool-v2-0-03f6c82d84fe@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/

Signed-off-by: Wenjia Zhang wenjz@qti.qualcomm.com
Signed-off-by: Abhinaba Rakshit abhinaba.rakshit@oss.qualcomm.com
qcom-next PR: qualcomm-linux/kernel-topics#1547
CRs-Fixed: 4618814

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4618814 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4618814
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4618814 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4618814
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qlijarvis]

PR #848 — validate-patch

PR: #848

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

1. Lore link present: Yes - but both links return HTTP 404 errors (patches never posted to lore.kernel.org)
2. Lore link matches PR commits: N/A - cannot compare because lore patches don't exist (404 errors)
3. Upstream patch status: Not posted upstream - lore URLs are invalid; patches were never submitted to the mailing list
4. PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #848 - Add ICE support for Hamoa (X1E80100)
Upstream commit: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/ (commit 1/2), https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/ (commit 2/2)
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	❌	Cannot verify - lore patches return 404
Body preserves rationale	❌	Cannot verify - lore patches return 404
Fixes tag present/correct	N/A	No Fixes tag (not a bugfix)
Authorship preserved	❌	Cannot verify - lore patches don't exist
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml	⚠️	Trailing tab character after qcom,x1e80100-inline-crypto-engine
arch/arm64/boot/dts/qcom/hamoa.dtsi	⚠️	Extra blank line added before cryptobam node (line 3092)

Issues

Critical:

1. Invalid lore links (404 errors): Both lore.kernel.org URLs return HTTP 404, meaning these patches were never posted to the mailing list. The FROMLIST: prefix is incorrect.

   • Commit 1: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/ → 404
   • Commit 2: https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/ → 404

2. Incorrect commit prefix: FROMLIST: indicates patches posted to a mailing list but not yet merged. Since these patches don't exist on lore, use:

   • PENDING: if work-in-progress not yet posted upstream
   • QCLINUX: if vendor-only with no upstream intent

3. Cannot verify authorship: Without the lore patches, cannot confirm whether the From: author and Signed-off-by: chain are correct for a FROMLIST: commit.

Minor:
4. Whitespace: Trailing tab in binding file (commit 1/2, line after qcom,x1e80100-inline-crypto-engine)
5. Formatting: Unnecessary blank line added in hamoa.dtsi (commit 2/2, line 3092)

Verdict

Reject - The lore links are invalid (404 errors), making the FROMLIST: prefix incorrect. These patches were never posted to the mailing list. The commits must be re-prefixed as PENDING: or QCLINUX: depending on upstream intent, and the lore links removed. Additionally, fix the trailing whitespace and extra blank line.

Final Summary

1. Lore link present: Yes - but both links return HTTP 404 errors (patches never posted to lore.kernel.org)
2. Lore link matches PR commits: N/A - cannot compare because lore patches don't exist (404 errors)
3. Upstream patch status: Not posted upstream - lore URLs are invalid; patches were never submitted to the mailing list
4. PR present in qcom-next/topics: Fail - 1/2 commit missing entirely, 1/2 partial match only (per integration_presence_report.md: "1/2 commit(s) are missing from both qcom-next and topics")

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 07f50dc44eddcf748a99d1a7523a466438bfffa6
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/2	[PATCH 1/2] FROMLIST: qcom,inline-crypto-engine: Add x1e80100 support	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing
2/2	[PATCH 2/2] FROMLIST: hamoa: Add ICE node for UFS inline encryption	partial - subject or partial tree evidence found, but full change was not verified	missing - no subject, patch-id, or full tree-content match found	partial

Final Status

overall_status: FAIL
present_commits: 0/2
partial_commits: 1/2
missing_commits: 1/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics

[qlijarvis]

PR #848 — checker-log-analyzer

PR: #848
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29933398951

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	1 error (trailing whitespace), 1 check (multiple blank lines)
dt-binding-check	❌	YAML syntax error (tab character)
dtb-check	❌	Failed to match schema (caused by dt-binding-check failure)
sparse-check	⏭️	Skipped (no C/H files changed)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Link verification failed (patches not yet on lore)
tag-check	✅	Both commits have valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #848 - Add ICE node for UFS inline encryption on Hamoa (X1E80100)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29933398951
Target branch: qcom-6.18.y

Checker	Result	Summary
checkpatch	❌	1 error (trailing whitespace), 1 check (multiple blank lines)
dt-binding-check	❌	YAML syntax error (tab character)
dtb-check	❌	Failed to match schema (caused by dt-binding-check failure)
sparse-check	⏭️	Skipped (no C/H files changed)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Link verification failed (patches not yet on lore)
tag-check	✅	Both commits have valid FROMLIST: prefix

---

❌ checkpatch

Root cause: Commit 4e1cf20 has trailing whitespace (TAB character); commit f6f19f2 has multiple consecutive blank lines.

Failure details:

Commit 4e1cf205fdaf ("FROMLIST: qcom,inline-crypto-engine: Add x1e80100 support")
ERROR: trailing whitespace
#24: FILE: Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml:26:
+          - qcom,x1e80100-inline-crypto-engine^I$

Commit f6f19f25fd4f ("FROMLIST: hamoa: Add ICE node for UFS inline encryption")
CHECK: Please don't use multiple blank lines
#25: FILE: arch/arm64/boot/dts/qcom/hamoa.dtsi:3092:
 
+

Fix:

For commit 4e1cf20:

git rebase -i 4def074fd0b5   # mark 4e1cf205fdaf as 'edit'
# Remove the trailing TAB from line 26 of the binding file:
sed -i '26s/[[:space:]]*$//' Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
git add Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
git commit --amend --no-edit
git rebase --continue

For commit f6f19f2:

# During the same rebase, mark f6f19f25fd4f as 'edit'
# Remove the extra blank line at line 3092 of hamoa.dtsi
# (delete the added blank line between line 3091 and cryptobam node)
git add arch/arm64/boot/dts/qcom/hamoa.dtsi
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 4def074fd0b5..f6f19f25fd4f

---

❌ dt-binding-check

Root cause: YAML syntax error caused by TAB character at line 26 column 47 of qcom,inline-crypto-engine.yaml.

Failure details:

../Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml:26:47: 
  [error] syntax error: found character '\t' that cannot start any token (syntax)
../Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml:26:47: 
  found character '\t' that cannot start any token

Fix: Same as checkpatch fix above — remove the trailing TAB character from line 26.

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml

---

❌ dtb-check

Root cause: DTB validation failed because the binding schema could not be parsed (cascading failure from dt-binding-check).

Failure details:

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml: 
  ignoring, error parsing file
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dtb: /soc@0/crypto@1d88000: 
  failed to match any schema with compatible: ['qcom,x1e80100-inline-crypto-engine', 'qcom,inline-crypto-engine']
[... repeated for all hamoa/purwa/x1e001de DTBs ...]

Fix: Once the YAML syntax error in dt-binding-check is fixed, dtb-check will pass automatically. The compatible string qcom,x1e80100-inline-crypto-engine is correctly added to the binding; the schema just couldn't be loaded due to the TAB character.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/hamoa-iot-evk.dtb

---

❌ check-patch-compliance

Root cause: The lore.kernel.org links in the commit messages point to patches that have not yet been posted or are not yet accessible.

Failure details:

Checking commit: FROMLIST: qcom,inline-crypto-engine: Add x1e80100 support
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/

Checking commit: FROMLIST: hamoa: Add ICE node for UFS inline encryption
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/

Fix: This failure will resolve automatically once the patches are posted to the mailing list and indexed by lore.kernel.org. The Link: tags are correctly formatted; the checker simply cannot fetch them yet because they haven't been posted upstream.

Action: Post the patch series to the upstream mailing list, then re-trigger CI after lore indexes the messages (typically within a few minutes).

Reproduce locally:

b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/

---

Verdict

3 blockers must be fixed before merge:

1. Trailing whitespace — Remove TAB character from qcom,inline-crypto-engine.yaml:26
2. Multiple blank lines — Remove extra blank line from hamoa.dtsi:3092
3. check-patch-compliance — Post patches to upstream mailing list (or wait for them to be indexed)

Once the whitespace issues are fixed, dt-binding-check and dtb-check will pass automatically. The check-patch-compliance failure is expected for FROMLIST: patches that haven't been posted yet — this will resolve once the series is sent upstream.