Skip to content

FROMLIST: Enable ICE for UFS on Hamoa IoT EVK#1547

Open
wenjz-qualcomm wants to merge 2 commits into
qualcomm-linux:tech/all/dt/hamoafrom
wenjz-qualcomm:hamoa_ufs_ice
Open

FROMLIST: Enable ICE for UFS on Hamoa IoT EVK#1547
wenjz-qualcomm wants to merge 2 commits into
qualcomm-linux:tech/all/dt/hamoafrom
wenjz-qualcomm:hamoa_ufs_ice

Conversation

@wenjz-qualcomm

Copy link
Copy Markdown

This series enables the Inline Crypto Engine (ICE) hardware for UFS
storage on the Qualcomm X1E80100 (Hamoa IoT EVK) platform.

The ICE hardware provides AES-256-XTS inline encryption/decryption for
UFS storage, offloading cryptographic operations from the CPU. The
hardware version on this platform is ICE v4.0.1 with HWKM v2 support.

Validation:

  • Probe successfully
  • Standard key work well

Patch 1 adds the new compatible string to the DT binding documentation.
Patch 2 adds the ICE device node to the Hamoa DTSI.

Link: https://lore.kernel.org/all/20260722-devtool-v2-0-03f6c82d84fe@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/

Signed-off-by: Wenjia Zhang wenjz@qti.qualcomm.com

Document the compatible string for inline crypto engine found
on the Qualcomm X1E80100 SoC, used by the Hamoa IoT EVK board.

Link: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/
Signed-off-by: Wenjia Zhang <wenjz@qti.qualcomm.com>
Add the Inline Crypto Engine (ICE) device node to describe the
hardware-accelerated inline encryption for UFS storage on the
Hamoa IoT EVK board (Qualcomm X1E80100 SoC).

Link: https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/
Signed-off-by: Wenjia Zhang <wenjz@qti.qualcomm.com>
@qcomlnxci
qcomlnxci requested review from a team, jingyiwang42, Dmitry Baryshkov (lumag) and Shiraz Hashim (shashim-quic) and removed request for a team July 22, 2026 10:24
@qlijarvis

Copy link
Copy Markdown

PR #1547 — validate-patch

PR: #1547

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes - but both links return HTTP 404 errors (not found on lore.kernel.org)
  2. Lore link matches PR commits: N/A - cannot verify due to 404 errors; patches may not have been posted to mailing list yet
  3. Upstream patch status: Unknown - lore links are invalid (404); patches appear to not exist on lore.kernel.org as of 2026-07-22
  4. PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1547 - Add X1E80100 ICE support for Hamoa
Upstream commit: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/ (commit 1/2), https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/ (commit 2/2)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify - lore links return 404
Body preserves rationale ⏭️ Cannot verify - lore links return 404
Fixes tag present/correct N/A - no Fixes tag expected for new feature additions
Authorship preserved ⏭️ Cannot verify - lore links return 404
Backport note (if applicable) N/A FROMLIST prefix used - not a backport

Diff

File Status Notes
Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml ⏭️ Cannot verify against lore - 404 error
arch/arm64/boot/dts/qcom/hamoa.dtsi ⏭️ Cannot verify against lore - 404 error

Issues

Critical Issues:

  1. Lore links are invalid (404 errors) - Both lore.kernel.org URLs in the commit messages return HTTP 404:

    • Commit 1/2: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/
    • Commit 2/2: https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/

    This indicates either:

    • The patches have not been posted to the mailing list yet
    • The message-IDs are incorrect
    • The patches were posted but not yet indexed by lore.kernel.org
  2. Integration presence failure - Per integration_presence_report.md:

    • Commit 1/2: missing from both qcom-next and topics branches
    • Commit 2/2: partial match in qcom-next (subject or partial tree evidence found, but full change not verified), missing from topics
    • Overall status: FAIL - 1/2 commits completely missing, 1/2 partial
  3. FROMLIST prefix with non-existent upstream - The commits use FROMLIST: prefix, which indicates they should be posted to a mailing list and have valid lore.kernel.org links. However, the links are invalid (404), making this prefix inappropriate. The correct prefix should be:

    • PENDING: if the patches are work-in-progress and not yet posted
    • QCLINUX: if these are vendor-only changes with no upstream intent

Verdict

Do not merge. The PR has multiple critical issues:

  1. Invalid lore.kernel.org links prevent verification of patch faithfulness to upstream
  2. Commits are missing or only partially present in qcom-next/topics integration branches
  3. The FROMLIST: prefix is inconsistent with the non-existent upstream posting

Required actions before merge:

  • If patches have been posted upstream: Update the Link: tags with valid lore.kernel.org URLs
  • If patches have not been posted yet: Change prefix from FROMLIST: to PENDING:
  • Ensure commits are fully integrated into qcom-next or the appropriate topic branch before merging to kernel-topics

Final Summary

  1. Lore link present: Yes - but both links return HTTP 404 errors (not found on lore.kernel.org)
  2. Lore link matches PR commits: N/A - cannot verify due to 404 errors; patches may not have been posted to mailing list yet
  3. Upstream patch status: Unknown - lore links are invalid (404); patches appear to not exist on lore.kernel.org as of 2026-07-22
  4. PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics; commit 1/2 completely missing, commit 2/2 only partially matched in qcom-next

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 07f50dc44eddcf748a99d1a7523a466438bfffa6
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: qcom,inline-crypto-engine: Add x1e80100 support missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/2 [PATCH 2/2] FROMLIST: hamoa: Add ICE node for UFS inline encryption partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: FAIL
present_commits: 0/2
partial_commits: 1/2
missing_commits: 1/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1547 — checker-log-analyzer

PR: #1547
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29911774787

Checker Result Summary
Checker Result Summary
checkpatch Passed
dt-binding-check Passed
dtb-check Passed
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance b4 fetch failed for both commits
tag-check Both commits have valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1547 - Add ICE support for Hamoa (X1E80100)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29911774787
Target branch: tech/all/dt/hamoa

Checker Result Summary
checkpatch Passed
dt-binding-check Passed
dtb-check Passed
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance b4 fetch failed for both commits
tag-check Both commits have valid FROMLIST: prefix

❌ check-patch-compliance

Root cause: The checker failed to fetch patches from lore.kernel.org using b4 am for both commits.

Failure details:

Checking commit: FROMLIST: qcom,inline-crypto-engine: Add x1e80100 support
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/

Checking commit: FROMLIST: hamoa: Add ICE node for UFS inline encryption
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/

Analysis:

The lore.kernel.org links are properly formatted and present in both commits:

  • Commit 1: Link: https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/
  • Commit 2: Link: https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/

Both commits have the required FROMLIST: prefix and proper Link: trailers. The failure is due to one of these reasons:

  1. Lore indexing delay — The patches were posted on 2026-07-22 (today), and lore.kernel.org may not have indexed them yet when the CI ran. Lore typically has a delay of a few minutes to hours.

  2. Future timestamp issue — The message-IDs contain 20260722 (July 22, 2026), which is today's date. If the patches were posted very recently or the CI ran before lore completed indexing, b4 would fail to fetch them.

  3. Network/transient issue — Temporary connectivity issue between the CI runner and lore.kernel.org.

Fix:

This is not a patch defect. The commits are properly formatted with correct prefixes and Link trailers. The issue is timing-related.

Recommended actions:

  1. Wait and re-trigger CI — Wait 15-30 minutes for lore to fully index the patches, then re-run the checker workflow.

  2. Verify links manually — Open the lore URLs in a browser to confirm they are accessible:

  3. Test locally — Run the suggested b4 am commands locally to verify the patches are fetchable:

    b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260722-devtool-v2-1-03f6c82d84fe@oss.qualcomm.com/
    b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260722-devtool-v2-2-03f6c82d84fe@oss.qualcomm.com/

Reproduce locally:

cd /path/to/kernel
git fetch origin pull/1547/head
git checkout FETCH_HEAD
../kernel-checkers/check-patch-compliance.sh --base <base_sha> --head <head_sha>

Verdict

One transient blocker — The check-patch-compliance failure is due to lore.kernel.org indexing delay or network timing, not a patch defect. All other checkers passed or skipped appropriately.

Recommendation: Re-trigger CI after 15-30 minutes to allow lore indexing to complete. The patches are correctly formatted with proper FROMLIST: prefixes and Link: trailers. No code changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants