Adds tool: redact_metadata#406
Open
Macabe222 wants to merge 8 commits into
Open
Conversation
2 tasks
Oddant1
reviewed
Jun 30, 2026
Oddant1
left a comment
Oddant1
left a comment
Member
There was a problem hiding this comment.
- Use term
ResultnotArtifactbecauseResultencompassesArtifactsandVisualizations - The Results used in the tests don't exist, so the tests are failing
Comment on lines
+2022
to
+2024
| self.tax_fp = os.path.join(datadir, 'taxonomy.qza') | ||
| self.tax_bar_fp = os.path.join(datadir, 'taxa-bar-plots.qzv') | ||
| self.demux_fp = os.path.join(datadir, 'demux.qza') |
Member
There was a problem hiding this comment.
These three Results don't actually exist. You'll need to create dummy_plugin Results to use for this. You can probably make them in code instead of creating test data in the data dir.
|
|
||
|
|
||
| class TestRedactMetadata(unittest.TestCase): | ||
| def setUp(self): |
Member
There was a problem hiding this comment.
Aim to make this setUpClass if possible.
Member
|
@Macabe222 don't use them big ole test Artifacts. Use this dummy_plugin method to create test data with Metadata in the prov. Also, don't worry about the CI failure. That's my fault lol. I'll make sure things work before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a tool that removes all metadata files from a given artifact.
Linked to: rachis-org/rachis#947
Succeeds #399
AI Disclosure
AI Usage Details