Skip to content

Add missing type hints in pyyaml.constructor #15746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 1 commit into from
May 9, 2026
+2 −2
Merged

Add missing type hints in pyyaml.constructor #15746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stubs/PyYAML/yaml/constructor.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ class BaseConstructor:
def get_data(self): ...
def get_single_data(self) -> Any: ...
def construct_document(self, node): ...
def construct_object(self, node, deep=False): ...
def construct_object(self, node, deep: bool = False): ...
Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're looking at this there's probably a lot more low-hanging fruit, lots of missing annotations around here.

def construct_scalar(self, node: ScalarNode) -> str: ...
def construct_sequence(self, node: SequenceNode, deep: bool = False) -> list[Any]: ...
def construct_mapping(self, node: MappingNode, deep: bool = False) -> dict[Hashable, Any]: ...
def construct_pairs(self, node, deep=False): ...
def construct_pairs(self, node, deep: bool = False): ...
@classmethod
# Use typevars so we can have covariant behaviour in the parameter types
def add_constructor(cls, tag: str, constructor: Callable[[_L, _N], Any]) -> None: ...
Expand Down
Loading