Add missing type hints in pyyaml.constructor#15746
Merged
JelleZijlstra merged 1 commit intopython:mainfrom May 9, 2026
Merged
Conversation
This is the same as 84682a1 which missed these for some reason.
JelleZijlstra
approved these changes
May 9, 2026
| def get_single_data(self) -> Any: ... | ||
| def construct_document(self, node): ... | ||
| def construct_object(self, node, deep=False): ... | ||
| def construct_object(self, node, deep: bool = False): ... |
Member
There was a problem hiding this comment.
If you're looking at this there's probably a lot more low-hanging fruit, lots of missing annotations around here.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: schemathesis (https://github.com/schemathesis/schemathesis)
+ src/schemathesis/core/deserialization.py:172: error: Unused "type: ignore" comment [unused-ignore]
+ src/schemathesis/core/deserialization.py:173: error: Unused "type: ignore" comment [unused-ignore]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as 84682a1 which missed these for some reason.
@srittau or @JelleZijlstra who were tagged on the aforementioned commit.