Repository navigation
feat(journeys): journeys in the HTML report, compare and MCP summaries - #10
Merged
Merged
Conversation
…est think time and compare
# Conflicts: # CHANGELOG.md # README.md # cli/src/prescale_cli/commands/run.py # cli/src/prescale_cli/journeys/load.py # cli/src/prescale_cli/journeys/replay.py # cli/src/prescale_cli/loadtest.py # cli/src/prescale_cli/render.py # cli/src/prescale_cli/schema/result.schema.json # cli/tests/test_journeys_load.py
…sive rows, escaped cells
# Conflicts: # CHANGELOG.md # README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #9. The base is #9's branch, so the diff shows only this slice. It gets retargeted to
mainonce #9 merges.Journey results now show up wherever results show up:
--html,show --html): a Journeys section with each journey's verdict (survives, band, the step that breaks first, why), the combined run with any interference, and the--expectanswer.prescale compare(terminal,--json,--markdown) diffs each journey by name. In a journey run, a drop past the threshold in any journey is a regression, even when it isn't the weakest journey. That matches the settled M4 rule: confidence labels a regression, it doesn't gate it. A journey that held everything it was tested to, below the old level, is inconclusive, not a drop. New, removed and stale journeys are listed, never counted as regressions.--expectanswer.How it was verified
Two real runs of browse + checkout: one against the example shop, one against a copy with a 10-connection pool instead of 25 (like a bad deploy).
culprit_journey: checkout,breaks_at_step: "3. place order (POST /api/carts/{{cart_id}}/order)",together.interference: {users_at_break: 15, held_alone: 20},expect.meets: false. About 1.6 KB.|in names escaped in markdownruff check cli/src: clean ·pytest cli/tests -q: 314 passed.Risk
Tier: risky · Public surface:
compare --jsongainsjourneysrows;--fail-on-regressionfails on a drop past the threshold in any journey of a journey run; the MCP summary gainsjourneys,togetherandexpect; the HTML report gains a section. Rollback: revert. These are renderers and comparison logic only; nothing stored or uploaded changes.Fresh-context review: ok to ship. All its should-fixes are taken:
|is escaped in markdown cellsNotes for review
prescale ciand the GitHub Action still run URL mode with their own comparison. Journeys in CI (with--stale warn|failand a per-journey PR comment) is the next PR, J1.4b.Generated by Claude Code