Repository navigation
feat(journeys): prescale ci and the Action replay journeys, with --stale - #11
Merged
Merged
Conversation
…est think time and compare
# Conflicts: # CHANGELOG.md # README.md # cli/src/prescale_cli/commands/run.py # cli/src/prescale_cli/journeys/load.py # cli/src/prescale_cli/journeys/replay.py # cli/src/prescale_cli/loadtest.py # cli/src/prescale_cli/render.py # cli/src/prescale_cli/schema/result.schema.json # cli/tests/test_journeys_load.py
…sive rows, escaped cells
# Conflicts: # CHANGELOG.md # README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #10. The base is #10's branch, so the diff shows only this slice. Paired with pyjeebz/prescale-web#2: the dashboard compares runs only with a baseline of the same mode.
When the checkout has
prescale/journeys/,prescale ci(and so the GitHub Action) replays the journeys at load instead of the URL routes: each alone, then together. It uploads the run and keeps one PR comment with each journey's verdict, the step that breaks first, interference, and any journey that wasn't load-tested. A deploy event with no checkout stays a URL run.Each journey that doesn't replay with one user gets an outcome:
--stale warnit's an::warning::; with--stale fail/stale: failit fails the check.New Action inputs:
staleandallow-writes. They're passed to the CLI only when set, so a pinned olderprescale-versionkeeps working. Journey secrets ({{env.NAME}}) come from the step'senv:.Fail-safe until the dashboard ships #2: a journey run only trusts the dashboard's comparison if it says
mode: "journeys". Otherwise the PR comment shows the journey verdicts with no "regressed" headline, and--fail-on-regressiondoesn't fire. A journey run can't be judged against a URL baseline.How it was verified
prescale ci --app "python examples/fragile-shop.py 8424", against a local stand-in for the dashboard that answers with a "regressed" comparison withoutmode, and with one journey file broken:--fail-on-regressionPOST /api/carts/{{cart_id}}/order"config.mode: journeysSHOP_PASSWORD=TopSecret123. The secret appears 0 times in the PR comment and the log. Locally,journeys verifyshows the body with"password":"***".prescale ci http://localhost:9→ exit 1 with::error::… failed with a single user.bash -eo pipefailwith a stubprescale:warn/empty → no--staleflagFail→--stale faila.com, b.com→ two--allow-writes$(touch PWNED) *stays literal textruff check cli/src: clean ·pytest cli/tests -q: 329 passed (15 new).Risk
Tier: risky · Public surface:
action.ymlinputsstaleandallow-writesciflags--stale,--allow-writes,--direrror(in the schema)Rollback: revert. The Action reaches users only when
v1moves (a release); if a release is wrong, movev1back. Release order: ship pyjeebz/prescale-web#2 before movingv1, so URL runs never compare with a journey baseline either.Fresh-context review blocked three real problems, all reproduced, fixed and pinned by tests:
--staleflag, which would break users pinned to an older CLI.Also from the review:
@notifications, no HTML, no breaking out of code spans::error::annotations--pathis noted as ignored for journeysGenerated by Claude Code