fix: allow empty string comparison - #386
Closed
jst-cyr wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Clement Le Roux <clement.le.roux@claranet.com>
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
- Coverage 90.99% 89.00% -2.00%
==========================================
Files 6 6
Lines 733 855 +122
==========================================
+ Hits 667 761 +94
- Misses 66 94 +28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
All green, Code coverage report shows project coverage is below threshold, but that is not this PRs fault |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is created to execute tests for the original PR (#384)