fix: allow empty string comparison - #384
Open
Clebam wants to merge 1 commit into
Open
Conversation
Clebam
force-pushed
the
main
branch
3 times, most recently
from
August 27, 2026 11:14
2b9650a to
c2b9b3b
Compare
Member
|
Running CI tests for this PR via #386 |
Member
|
I ran the acceptance tests as a branch, instead of a fork, just in case there would be a different logical path in the testing. Changes are still green (though code coverage tool is reporting that the project is not hitting the target, but that is unrelated to this PR). Given the targeted nature of the change, and the fact it is restoring a previous bug fix that was undone by a recent PR, I suggest we move forward with this fix and release it as a patch release before we put any major releases out so that the current version is patched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle empty string nullification
Handle testing to validate empty string behavior ==> should compare
empty array and empty hash ==> still nullified
Additional Context
This PR changed the behavior upon the comparison and the previously fixed caveat of empty string being nullified has been lost
Related Issues (if any)
This is a closed issue but the problem reappeared #264
Checklist