Repository navigation
Add --in-process mode support - #234
Conversation
vstinner
left a comment
There was a problem hiding this comment.
I would prefer to limit this PR to the --in-process option, and move the PyOdide changes to a separated PR (later).
|
@vstinner Sure, sounds good. I remove pyodide-related changes from the PR. |
|
@ryanking13 I will take a look at this week cc @vstinner @hoodmane |
corona10
left a comment
There was a problem hiding this comment.
Overall looks good to me, but could you check the https://github.com/psf/pyperf/pull/234/changes#r4341703877 this change is actually needed.
|
Thanks @corona10! Is there any plan to release a new version? |
|
Let me do at this week |
|
@ryanking13: Would you mind to create a follow-up PR to document the new option in https://pyperf.readthedocs.io/en/latest/runner.html? |
|
So I tried I don't see the purpose of computing more than 1 warmup value in total if all values are computed in the same process. Moreover, I don't see the purpose of having 20 "runs" if we are computing all of them in the same process. Instead, I would expect to have 1 run for the loops calibration and 1 run with 60 values. |
|
I created #271 to compute all values in a single process. |
Oh, please add also an entry in doc/changelog.rst (you should add a new Version 2.11 section). |
Sure will do! |
Resolve #233
Adds
--in-processmode as proposed in #233. It enables running pyperf in browser-based environments like Pyodide.