Repository navigation
Make psutil optional in emscripten platform - #269
Merged
Merged
Conversation
Member
|
Can you post the traceback/error message that you get? |
Contributor
Author
Do you mean when installing pyperf on emscripten? Here is what I get using uv's emscripten build which uses Pyodide in the backend. $ uv venv --python pyodide-3.14.2-emscripten-wasm32-musl
$ uv pip install pyperf
error: Failed to build `psutil==7.2.2` cause: The build backend returned an error
cause: Call to `setuptools.build_meta.get_requires_for_build_wheel` failed (exit status: 1)
[stderr]
platform emscripten is not supported
hint: `psutil` (v7.2.2) was included because `pyperf` (v2.10.0) depends on `psutil`
hint: Build failures usually indicate a problem with the package or the build environment |
Member
|
Oh ok, the error message comes from psutil setup.py: https://github.com/giampaolo/psutil/blob/c7e6eb945a525f57c3843284e8f66ef4701af02c/setup.py#L368. |
Member
|
Merged, thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #234
psutildoesn't (and never) work in emscripten since it requires hardware access, so disabling it so that installing pyperf do not fail on emscripten platforms.