[WALLET-202] Add US nationality scope - #46
matt-russo-notarize merged 4 commits into
Conversation
frostevent
left a comment
There was a problem hiding this comment.
@matt-russo-notarize do we need a new subclass of ProofCredential in https://github.com/proof/proof-vc-common/blob/main/packages/server/src/proof_credentials.ts? If CI is passing, can we make sure we add a test that would break if you have need credential types without their class counterpart?
|
@frostevent I don't think we need a new subclass since it is still a Also i added exhaustiveness checks for credential types<->classes and ids to confirm the unions are adhered to. |
| DEFAULT_CREDENTIAL_ID, | ||
| NATIONALITY_US_CREDENTIAL_ID, | ||
| ]; | ||
| const CREDENTIAL_ID_SET = { |
There was a problem hiding this comment.
Why do we need CREDENTIAL_ID_SET?
There was a problem hiding this comment.
it's so we check satisfies on compile to ensure no new CredentialType member is added without a matching class name.
added a comment about it and removed the export
Adds the new US nationality scope.
CredentialIDandScopeintodefault | nationalityCREDENTIAL_IDSverifyVPTokento initialize all credential ids to[]to match theVPToken's shape