Skip to content

fix(prober-queue): time out scans from job enqueue time, not created_at #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Jul 6, 2026
Merged

fix(prober-queue): time out scans from job enqueue time, not created_at #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/prober-queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,10 @@ export async function processDuePortScans(

for (const scan of (runningRows ?? []) as ScanRow[]) {
const job = (await q.getJob(scan.id)) as Job | undefined;
const age = Date.now() - new Date(scan.created_at).getTime();

if (!job) {
if (age > RUNNING_TIMEOUT_MS) {
// No job and an old row => the job was lost (not just slow to enqueue).
if (Date.now() - new Date(scan.created_at).getTime() > RUNNING_TIMEOUT_MS) {
await markFailed(supabase, scan.id, "prober job missing");
failed++;
}
Expand All @@ -168,7 +168,10 @@ export async function processDuePortScans(
} else if (state === "failed") {
await markFailed(supabase, scan.id, job.failedReason ?? "prober job failed");
failed++;
} else if (age > RUNNING_TIMEOUT_MS) {
} else if (Date.now() - job.timestamp > RUNNING_TIMEOUT_MS) {
// Measure the timeout from when the job was ENQUEUED (job.timestamp), not
// when the scan row was created — a row can sit `queued` a long time
// before a job exists, and timing out from created_at kills fresh jobs.
await markFailed(supabase, scan.id, "scan timed out");
failed++;
}
Expand Down
Loading