Skip to content

Make the animated banner step say what it did #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Sep 24, 2026
Merged

Make the animated banner step say what it did #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/ads/video/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,13 +360,19 @@ export async function renderPreroll(args: {
// revision whose video is fine, because the video is what the advertiser is
// waiting for. The problems are recorded either way.
if (args.probeGif) {
// Logged unconditionally. The banner step failed silently in production for
// three deploys while working when invoked by hand in the same container,
// and the only reason that was hard to diagnose is that success and
// never-ran looked identical from outside.
console.log("[render] animated banners: start");
try {
const gifs = await renderAnimatedBanners({
snapshot,
workDir,
captureFrames,
probeGif: args.probeGif,
});
console.log(`[render] animated banners: produced ${gifs.length}`);
for (const g of gifs) {
const facts = await fileFacts(g.file);
assets.push({
Expand All @@ -393,7 +399,7 @@ export async function renderPreroll(args: {
// — while the code did the opposite and failed whole renders whose video
// was fine. The banners are optional profiles; their absence is visible
// in the asset list, and the reason belongs in the log.
console.warn(`[render] animated banners skipped: ${(err as Error).message}`);
console.error(`[render] animated banners FAILED: ${(err as Error).message}`);
}
}

Expand Down