Make the animated banner step say what it did - #289
Merged
Merged
Conversation
The banner step produced nothing in three consecutive production renders while the same code, in the same container, produced all three banners when invoked by hand. That was hard to diagnose for one reason: success and never-ran looked identical from outside, because the only output on the failure path was a console.warn that never appeared in the logs. It now logs on entry, logs how many banners it produced, and logs a failure at error level. The next render says which of the three happened. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ThreatCrush Security Scan48 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 31 | LOW: 15
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The banner step produced nothing in three consecutive production renders while the same code, in the same container, produced all three banners when invoked by hand via
renderPreroll— 8 profiles, 0 problems.That was hard to diagnose for exactly one reason: success and never-ran looked identical from outside. The only output on the failure path was a
console.warnthat never appeared in the logs.It now logs on entry, logs how many banners it produced, and logs failures at error level. The next render will say which of the three actually happened.
No behaviour change. Typechecks clean.