Skip to content

Say why a campaign has no pre-roll instead of showing nothing #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Sep 24, 2026
Merged

Say why a campaign has no pre-roll instead of showing nothing #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/(app)/dashboard/ads/[id]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { AdPreview } from "@/components/ads/ad-preview";
import { VideoRenderCard } from "@/components/ads/video-render-card";
import { latestJobForCampaign } from "@/lib/ads/video/jobs";
import { isStreamingFormat } from "@/lib/ads/formats";
import { classifyCampaign } from "@/lib/ads/video/classify";
import { CampaignActions, RegenerateButton } from "@/components/ads/campaign-actions";
import { CampaignTrend } from "@/components/ads/campaign-trend";
import { BidHistory } from "@/components/ads/bid-history";
Expand Down Expand Up @@ -274,7 +275,7 @@ export default async function CampaignDetailPage({
</div>

<div className="mt-6">
<VideoRenderCard jobId={videoJobId} />
<VideoRenderCard jobId={videoJobId} campaignKind={classifyCampaign(campaign.destination_url)} />
</div>

{creatives.length > 0 && (
Expand Down
35 changes: 30 additions & 5 deletions components/ads/video-render-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,14 @@ type Ready = Extract<Status, { ok: true }>;
* deliberately unhurried: an encode takes tens of seconds, and polling faster
* would only make the queue look busier than it is.
*/
export function VideoRenderCard({ jobId }: { jobId: string | null }) {
export function VideoRenderCard({
jobId,
campaignKind = "product",
}: {
jobId: string | null;
/** What this campaign advertises. Only used to explain an absent pre-roll. */
campaignKind?: "product" | "blog" | "social";
}) {
const [status, setStatus] = useState<Ready | null>(null);
const [error, setError] = useState<string | null>(null);
const timer = useRef<ReturnType<typeof setTimeout> | null>(null);
Expand Down Expand Up @@ -50,10 +57,28 @@ export function VideoRenderCard({ jobId }: { jobId: string | null }) {
};
}, [jobId, settled, poll]);

// No job means this campaign predates the video pipeline, or its render was
// never queued. Saying nothing beats showing a broken-looking empty card on
// every older campaign.
if (!jobId) return null;
// No job. Rendering nothing here was worse than it sounds: a campaign that
// was deliberately skipped and one that is broken looked identical, so the
// only signal was an absence the advertiser had to interpret. Say which.
if (!jobId) {
const reason =
campaignKind === "blog"
? "This campaign links to a blog post, and the initial rollout covered product ads only."
: campaignKind === "social"
? "This campaign links to a social profile, and the initial rollout covered product ads only."
: "This campaign predates the video pipeline.";
return (
<div className="card p-4">
<h2 className="font-semibold">Streaming pre-roll</h2>
<p className="mt-1 text-sm text-[var(--color-muted)]">
No pre-roll yet. {reason}
</p>
<p className="mt-2 text-xs text-[var(--color-muted)]">
Editing and saving this campaign queues one.
</p>
</div>
);
}

return (
<div className="card p-4">
Expand Down