Say why a campaign has no pre-roll instead of showing nothing - #281
Merged
Merged
Conversation
The render card returned null whenever a campaign had no video job, so a campaign deliberately skipped by the rollout and one that is broken looked exactly the same: an absence the advertiser had to interpret. The first person to open a blog-linking campaign reasonably read it as the feature failing. Now it says which, and that editing and saving the campaign queues one — which is true, because the save path queues a render for any campaign regardless of what it links to. Only the backfill was restricted to product ads. The campaign kind is classified on the page from the destination, reusing the same classifier the backfill uses, so the explanation cannot drift from the rule that actually decided. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ThreatCrush Security Scan48 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 31 | LOW: 15
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported from
/dashboard/ads/3519dd6f-…: "I didn't see it on this one."The campaign points at
moshcode.sh/blog/the-agentic-internet-they-dont-want-you-to-see— a blog post, deliberately excluded from the backfill, which covered product ads only. So there was genuinely no pre-roll.The defect is that the card returned
nullin that case. A campaign that was deliberately skipped and one that is broken looked identical: an absence the advertiser had to interpret. The first person to open a blog-linking campaign reasonably read it as the feature failing.The fix
Say which, and say what to do about it:
That last line is true and worth stating: the save path queues a render for any campaign, regardless of what it links to. Only the backfill was restricted to product ads. So an excluded campaign is one edit away from having a video, and nobody has to ask.
The kind is classified on the page from the destination, reusing the same
classifyCampaignthe backfill uses, so the explanation can't drift from the rule that actually decided.Verification
2551 passed / 1 failed repo-wide — the pre-existing
tracker-geofailure (mmdb not installed locally). Typecheck clean. The 9 classifier tests still pin the real production URL shapes.