Fix feedback submissions rejected by metadata validation - #256
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (2)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. Summary by CodeRabbit
WalkthroughThe feedback payload now serializes Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The feedback payload supplies the required metadata fields with no remaining merge-blocking issue. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
wmadden
approved these changes
Sep 11, 2026
wmadden
pushed a commit
that referenced
this pull request
Sep 11, 2026
…258) ## Summary Every `npm install` of `@prisma/cli` and `prisma` has hung since 2026-09-11 03:55 UTC, and the conformance step in CI runs until cancelled (for example https://github.com/prisma/prisma-cli/actions/runs/34586396643/job/103242148710 on #256). The cause is two levels down: `@prisma/composer@0.17.0` left alchemy's floating `@effect/vitest` dependency unpinned for consumers, the `@effect/*` adapters published `4.0.0-rc.114` ahead of `effect` itself, and npm backtracks for hours over an `effect` peer that no published version satisfies instead of failing. composer 0.18.0 pins that dependency (prisma/composer#287). This moves both shells to it, and the `@prisma/composer` dev dependency with them so the tree holds one composer version. No CLI behaviour changes: composer-cli 0.18.0 declares the same `@prisma/cli-engine@0.3.0` peer. ## Testing - `PUBLISH_CHANNEL=dev pnpm check:conformance` and `PUBLISH_CHANNEL=release pnpm check:conformance`: 5 subjects checked, nothing to report, about 50 s each. Before this change the sandbox install never finished. - `pnpm typecheck` clean. `pnpm --filter @prisma/cli test`: 964 passed, 2 skipped. - `pnpm lint` clean on tracked files. ## After merge #256 and any other open PR need main merged in, or a rerun on top of it, for their conformance check to pass. The already-published `8.0.0-rc.13` still pins composer-cli 0.17.0 and cannot be installed until the next release ships this pin, unless `effect@4.0.0-rc.114` lands upstream first. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prisma feedbackfails against the live service with HTTP 400:meta must be an object with string values.The engine migration changed the wire payload from flatnodeVersionmetadata to a nestedruntimeobject.Restore the service-compatible metadata fields (
cliVersion,nodeVersion,platform,arch) while preserving the CLI result's existing context shape. The local test server now rejects non-string metadata values, and the payload assertion checks the restored contract.Validation:
pnpm typecheckandpnpm lintpass.01a08fe1-2a2d-7000-8a55-b334e2488a5ewith exit code 0.Separate from artwork PR #253; no engine version or deployment changes.