fix(cli): pin @prisma/composer-cli 0.18.0 so npm installs terminate - #258
Merged
Conversation
Every npm install of @prisma/cli and prisma has hung since 2026-09-11 03:55 UTC, and the conformance check in CI ran until cancelled. The cause was two levels down: @prisma/composer@0.17.0 left alchemy's floating @effect/vitest dependency unpinned for consumers, the @effect adapters published 4.0.0-rc.114 ahead of effect itself, and npm backtracked for hours over an effect peer no published version satisfies. composer 0.18.0 pins that dependency (prisma/composer#287). Move both shells to it, and the @prisma/composer dev dependency with them, so the tree holds one composer version. Conformance passes on the dev and release channels; the sandbox install finishes in seconds again. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. Summary by CodeRabbit
WalkthroughThe pull request updates Composer dependencies from version 0.17.0 to 0.18.0. It updates both runtime and development dependencies in Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The dependency-only update is ready to merge; reported installation and validation checks pass. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every
npm installof@prisma/cliandprismahas hung since 2026-09-11 03:55 UTC, and the conformance step in CI runs until cancelled (for example https://github.com/prisma/prisma-cli/actions/runs/34586396643/job/103242148710 on #256). The cause is two levels down:@prisma/composer@0.17.0left alchemy's floating@effect/vitestdependency unpinned for consumers, the@effect/*adapters published4.0.0-rc.114ahead ofeffectitself, and npm backtracks for hours over aneffectpeer that no published version satisfies instead of failing.composer 0.18.0 pins that dependency (prisma/composer#287). This moves both shells to it, and the
@prisma/composerdev dependency with them so the tree holds one composer version. No CLI behaviour changes: composer-cli 0.18.0 declares the same@prisma/cli-engine@0.3.0peer.Testing
PUBLISH_CHANNEL=dev pnpm check:conformanceandPUBLISH_CHANNEL=release pnpm check:conformance: 5 subjects checked, nothing to report, about 50 s each. Before this change the sandbox install never finished.pnpm typecheckclean.pnpm --filter @prisma/cli test: 964 passed, 2 skipped.pnpm lintclean on tracked files.After merge
#256 and any other open PR need main merged in, or a rerun on top of it, for their conformance check to pass. The already-published
8.0.0-rc.13still pins composer-cli 0.17.0 and cannot be installed until the next release ships this pin, unlesseffect@4.0.0-rc.114lands upstream first.🤖 Generated with Claude Code