Skip to content

perf(react-compiler): enable token remove buttons #8554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshblack wants to merge 1 commit into from
Closed

perf(react-compiler): enable token remove buttons #8554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/react-compiler-token-remove-button.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': minor
---

Token, IssueLabelToken: Improve rendering performance with React Compiler support.
1 change: 0 additions & 1 deletion packages/react/script/react-compiler.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ const unsupportedPatterns = [
'src/SelectPanel/SelectPanel.test.tsx',
'src/SelectPanel/SelectPanel.tsx',
'src/Skeleton/SkeletonBox.figma.tsx',
'src/Token/_RemoveTokenButton.tsx',
'src/TreeView/TreeView.features.stories.tsx',
'src/TreeView/TreeView.tsx',
'src/deprecated/utils/create-slots.tsx',
Expand Down
6 changes: 3 additions & 3 deletions packages/react/src/Token/_RemoveTokenButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,14 @@ const RemoveTokenButton = ({
borderOffset = 0,
as: _as,
children: _children,
ref,
...rest
}: React.PropsWithChildren<RemoveTokenButtonProps & {as?: React.ElementType}>) => {
if (isParentInteractive) {
return (
<span
{...rest}
ref={ref as React.Ref<HTMLSpanElement>}
tabIndex={-1}
aria-label={ariaLabel}
data-size={size}
Expand All @@ -43,16 +45,14 @@ const RemoveTokenButton = ({

return (
<button
// eslint-disable-next-line react-hooks/refs
{...rest}
aria-label={'Remove token'}
data-size={size}
className={clsx(classes.TokenButton, className)}
style={{
transform: `translate(${borderOffset}px, -${borderOffset}px)`,
}}
// eslint-disable-next-line react-hooks/refs
ref={rest.ref as React.Ref<HTMLButtonElement>}
ref={ref as React.Ref<HTMLButtonElement>}
type="button"
>
<XIcon size={size === 'small' || size === 'medium' ? 12 : 16} />
Expand Down
Loading