Skip to content

perf(react-compiler): enable token remove buttons - #8554

Closed
joshblack wants to merge 1 commit into
joshblack/react-compiler-safe-timeoutfrom
joshblack/react-compiler-token-remove-button
Closed

joshblack wants to merge 1 commit into
joshblack/react-compiler-safe-timeoutfrom
joshblack/react-compiler-token-remove-button

Conversation

@joshblack

@joshblack joshblack commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Closes #

Enable React Compiler for the private remove button used by Token and IssueLabelToken as the second entry in our low-risk migration stack. Our migration report identifies accessing ref through the remaining props as the blocker.

Changelog

New

Changed

  • Destructure ref separately from the remaining props and preserve its existing span and button targets.
  • Remove the two ref lint suppressions and the compiler exclusion.
  • Add a minor changeset, matching our recent compiler rollout.

Removed

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>\nCopilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
@changeset-bot

changeset-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7abe551

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack
joshblack added this pull request to stack #8556 October 15, 2026 20:50
@github-actions github-actions Bot added the staff Author is a staff member label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 15, 2026
@joshblack
joshblack removed this pull request from stack #8556 October 15, 2026 20:55
@joshblack

Copy link
Copy Markdown
Member Author

Combined into #8555 so we can review these small compiler migrations in one PR.

This branch was successfully deployed

1 active and 1 inactive deployments
storybook-preview-8554 — 7abe5510 Deployed Oct 15, 2026 by github-actions[bot]
github-pages — 7abe5510 Deployed Oct 15, 2026 by joshblack via deploy-preview #33721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant