Repository navigation
Fix MCP usage routing and ConfirmationDialog URLs - #8530
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b764bc7b-e03b-4b61-a481-9e4933599d54
🦋 Changeset detectedLatest commit: b39fb00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The routing correction is focused, comprehensively tested, and accompanied by an appropriate changeset.
0 open findings
What changed in this PR
Fixes MCP usage-guideline routing by using component documentation slugs.
Changes:
- Routes guideline requests through canonical component slugs.
- Adds coverage for all advertised components and routing regressions.
- Adds a patch changeset.
| File | Description |
|---|---|
packages/mcp/src/server.ts |
Uses documentation slugs for guideline URLs. |
packages/mcp/src/server.test.ts |
Tests canonical routing and catalogue coverage. |
.changeset/twenty-crabs-lose.md |
Records the MCP routing fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b764bc7b-e03b-4b61-a481-9e4933599d54
joshfarrant
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b764bc7b-e03b-4b61-a481-9e4933599d54
joshblack
approved these changes
Oct 13, 2026
joshfarrant
enabled auto-merge
October 14, 2026 08:15
joshfarrant
added
the
integration-tests: skipped manually
tay1orjones
approved these changes
Oct 14, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8531
Usage-guideline requests use raw component IDs rather than documentation slugs. For example, the ActionBar request redirects to the Primer homepage, which is returned as if it were component guidance.
Use the existing slug for usage requests and correct the missing ConfirmationDialog alias in the existing mapper. The alias correction also fixes ConfirmationDialog requests through
get_componentandget_component_batch.Changelog
New
Individually named usage-routing cases for all 76 distinct advertised components, a catalogue coverage guard, and four single/batch ConfirmationDialog cases including lowercase input. Expected paths are literals; only external HTTP is mocked.
Changed
get_component_usage_guidelinesuses the existing documentation slug. The mapper resolvesconfirmationdialogtoconfirmation-dialog.Removed
None.
Rollout strategy
Patch release of
@primer/mcp; no interface change or consumer migration.Testing & Reviewing
All fixture URLs were reviewed against the deployed sitemap and actual document identity.