Skip to content

[TESTING] fix duplicate FormControl inputs in horizontal layout (workflow mirror) - #8523

Closed
tay1orjones wants to merge 1 commit into
mainfrom
tay1orjones-mirror-pr-8508
Closed

[TESTING] fix duplicate FormControl inputs in horizontal layout (workflow mirror)#8523
tay1orjones wants to merge 1 commit into
mainfrom
tay1orjones-mirror-pr-8508

Conversation

@tay1orjones

@tay1orjones tay1orjones commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related to #8487.

Just integration testing #8508 - will close once testing is complete

@namangoyal176-10 @tay1orjones
fix duplicate FormControl inputs in horizontal layout
7afb126 
Mirror PR #8508 for same-repository workflow testing. Preserve the original implementation and leave the source PR open.

Original commit: d453d97

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b6318031-063f-4ab0-a201-3855c4d9919a
Copilot AI balanced review requested due to automatic review settings October 7, 2026 22:17
@tay1orjones
tay1orjones requested a review from a team as a code owner October 7, 2026 22:17
@tay1orjones
tay1orjones requested a review from joshblack October 7, 2026 22:17
@changeset-bot

changeset-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7afb126

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@tay1orjones
tay1orjones removed the request for review from joshblack October 7, 2026 22:18
@tay1orjones tay1orjones changed the title fix duplicate FormControl inputs in horizontal layout (workflow mirror) [TESTING] fix duplicate FormControl inputs in horizontal layout (workflow mirror) Oct 7, 2026
Copilot AI reviewed Oct 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused fix matches existing vertical-layout behavior and includes appropriate regression coverage.

0 open findings

What changed in this PR

Fixes duplicate non-choice inputs in horizontal FormControl layouts.

Changes:

  • Filters all recognized input components after cloning.
  • Adds regression coverage and a patch changeset.
File Description
FormControl.tsx Prevents duplicate input rendering.
FormControl.test.tsx Tests horizontal layout behavior.
Changeset Documents the patch release.

🧠 Review effort: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions
github-actions Bot temporarily deployed to storybook-preview-8523 October 7, 2026 22:26 Inactive
@github-actions github-actions Bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 7, 2026
@primer-integration

primer-integration Bot commented Oct 7, 2026

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Passed  Changes   Passed
Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@github-actions github-actions Bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 7, 2026
@tay1orjones tay1orjones mentioned this pull request Oct 7, 2026
Merged
@tay1orjones tay1orjones closed this Oct 7, 2026

This branch was successfully deployed

1 active and 1 inactive deployments
storybook-preview-8523 — 7afb126d Deployed Oct 7, 2026 by github-actions[bot]
github-pages — 7afb126d Deployed Oct 7, 2026 by tay1orjones via deploy-preview #33614
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tay1orjones @namangoyal176-10