fix(FormControl): prevent duplicate input rendering in horizontal layout

[namangoyal176-10]

Summary

Fixes an issue where FormControl with layout="horizontal" renders duplicate non-choice inputs (such as TextInput, Textarea, Select, Autocomplete).

Root Cause

In packages/react/src/FormControl/FormControl.tsx, InputChildren clones and renders InputComponent into classes.ControlChoiceInputs. However, the subsequent filter over childrenWithoutSlots only excluded [Checkbox, Radio], allowing non-choice inputs to pass through and render a second time alongside the cloned element. In contrast, the vertical layout branch correctly filters out all expectedInputComponents.

Changes

• Updated the childrenWithoutSlots filter in InputChildren to exclude all expectedInputComponents (matching the vertical layout branch behavior).
• • Added a changeset patch for @primer/react.
• • Added a regression test in FormControl.test.tsx verifying that only one input is rendered when layout="horizontal" is used with a non-choice input.

Testing

• Ran Vitest:
• npx vitest run packages/react/src/FormControl/__tests__/
• Result: 3 test files passed, 45 tests passed.
• • Verified regression test failed before fix (expected 1 textbox, received 2) and passed after fix.
• • Ran TypeScript check:
• npx tsc --noEmit -> 0 errors.
• • Ran ESLint:
• npx eslint packages/react/src/FormControl/FormControl.tsx packages/react/src/FormControl/__tests__/FormControl.test.tsx -> 0 errors.
• • Ran Prettier:
• All matched files use Prettier code style.
  Closes FormControl renders duplicate non-choice inputs when layout="horizontal" #8487

[changeset-bot]

🦋 Changeset detected

Latest commit: 75fe563

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Copilot]

🟢 Approval recommended

The targeted fix is correct, tested, and appropriately documented.

0 open findings

What changed in this PR

Fixes duplicate non-choice inputs in horizontal FormControl layouts.

Changes:

• Filters all recognized input components from remaining children.
• Adds regression coverage and a patch changeset.

File	Description
FormControl.tsx	Prevents duplicate input rendering.
FormControl.test.tsx	Tests horizontal non-choice inputs.
Changeset	Documents the patch release.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

[tay1orjones]

lgtm, thanks!

[tay1orjones]

Integration tests look good #8523 (comment), so skipping here

[primer-integration]

Integration test results from github/github-ui PR:

  Changes Passed
  CI Passed
  VRT Passed
  Projects Passed

All checks passed!

[llastflowers]

.skip-integration-checks