feat(pixi_spec): support extras, flags and when on conda dependencies#6262
Open
Hofer-Julian wants to merge 1 commit into
Open
feat(pixi_spec): support extras, flags and when on conda dependencies#6262Hofer-Julian wants to merge 1 commit into
Hofer-Julian wants to merge 1 commit into
Conversation
3 tasks
c535ffc to
569bfbe
Compare
baszalmstra
requested changes
Jun 3, 2026
Contributor
baszalmstra
left a comment
There was a problem hiding this comment.
This PR merges some fundamental concepts.
Previously we had SourceLocationSpec which is just a reference to a source location. We renamed that to SourceSpec and added matchspec fields to the type. However, we also want to be able to refer to just the location, for instance when refering to where the manifest is or where the build source is. This now also always carries a matchspec which makes no sense in this context. I think we should split these concepts, have a SourceLocationSpec which refers to a location that we can checkout and where source is located, and a combination of a SourceLocationSpec and matchspec fields to refer to a specific package variant inside the source location.
c5b6e35 to
c49f753
Compare
c49f753 to
25d2f88
Compare
baszalmstra
requested changes
Jun 3, 2026
8 tasks
dcdcd6a to
9102884
Compare
Restructure PixiSpec into six explicit variants that separate source from binary locations, and embed matchspec selectors on the source variants so conda dependencies accept extras, flags and when. This is the plumbing and parsing that lets source and binary specs round-trip the repodata v3 fields. Based on "fix: support conda extras for satisfiabily and solve groups (#6260)".
9102884 to
cb295f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables
extras,flagsandwhento work with source dependencies.Also, recursive source dependencies work.
Example 1:
Example 2:
Example 3: