Skip to content

fix(satisfiability): detect extra-dependency drift for source packages#6263

Open
Hofer-Julian wants to merge 1 commit into
feat/pixi-spec-v3-fieldsfrom
fix/source-extra-drift
Open

fix(satisfiability): detect extra-dependency drift for source packages#6263
Hofer-Julian wants to merge 1 commit into
feat/pixi-spec-v3-fieldsfrom
fix/source-extra-drift

Conversation

@Hofer-Julian
Copy link
Copy Markdown
Contributor

Description

Compare the extra-dependency groups recorded in the lock file against what the backend re-derives from a source package manifest, and report a SourceExtraDependenciesChanged error when they diverge. The error lists the specs added and removed per extra group so the drift is actionable.

Based on #6262

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

Tools: Claude

@Hofer-Julian Hofer-Julian requested a review from baszalmstra June 3, 2026 09:45
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch 2 times, most recently from c535ffc to 569bfbe Compare June 3, 2026 10:00
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch from e8ebac8 to daa970b Compare June 3, 2026 10:01
Copy link
Copy Markdown
Contributor

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also add unsat test cases for the individual failure modes.

Comment thread crates/pixi_core/src/lock_file/satisfiability/source_record.rs Outdated
Comment thread crates/pixi_core/src/lock_file/satisfiability/source_record.rs Outdated
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch 2 times, most recently from a2946b1 to 3ee1563 Compare June 3, 2026 12:37
@Hofer-Julian Hofer-Julian requested a review from baszalmstra June 3, 2026 12:38
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch from 569bfbe to f8a83c3 Compare June 3, 2026 13:08
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch from 3ee1563 to 566ec16 Compare June 3, 2026 13:08
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch from f8a83c3 to aaa13a5 Compare June 3, 2026 14:30
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch from 566ec16 to 1cdd575 Compare June 3, 2026 14:30
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch from aaa13a5 to bdbbd5f Compare June 3, 2026 14:32
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch 2 times, most recently from a1d4ba1 to a411625 Compare June 3, 2026 14:36
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch 2 times, most recently from 4e7787c to 9946745 Compare June 3, 2026 14:45
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch 2 times, most recently from e8d427b to 75867c6 Compare June 3, 2026 14:46
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch 2 times, most recently from e0a1fa4 to c5b6e35 Compare June 3, 2026 14:50
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch from 75867c6 to 543fb68 Compare June 3, 2026 14:50
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch from c5b6e35 to c49f753 Compare June 3, 2026 14:53
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch 2 times, most recently from a9480c4 to ef785d8 Compare June 3, 2026 14:55
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch from c49f753 to 25d2f88 Compare June 3, 2026 14:55
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch from 25d2f88 to de782d4 Compare June 5, 2026 08:58
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch from ef785d8 to 4a1c37f Compare June 5, 2026 08:58
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch from de782d4 to 94e4dda Compare June 5, 2026 09:00
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch from 4a1c37f to 5dde8d0 Compare June 5, 2026 09:00
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch from 94e4dda to f3f1666 Compare June 5, 2026 09:32
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch from 5dde8d0 to 74ea88d Compare June 5, 2026 09:32
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch from f3f1666 to dcdcd6a Compare June 5, 2026 09:35
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch from 74ea88d to 6e38391 Compare June 5, 2026 09:35
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch from dcdcd6a to 9102884 Compare June 5, 2026 12:22
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch from 6e38391 to c79b759 Compare June 5, 2026 12:22
Compare the extra-dependency groups recorded in the lock file against what the backend re-derives from a source package manifest, and report a SourceExtraDependenciesChanged error when they diverge. The error lists the specs added and removed per extra group so the drift is actionable.

Based on "feat(pixi_spec): support extras, flags and when on conda dependencies".
@Hofer-Julian Hofer-Julian force-pushed the feat/pixi-spec-v3-fields branch from 9102884 to cb295f4 Compare June 5, 2026 12:42
@Hofer-Julian Hofer-Julian force-pushed the fix/source-extra-drift branch from c79b759 to a7ef33f Compare June 5, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants