Autogenerate version if skew is enabled - #95
Merged
Merged
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
requested review from
ShogunPanda,
ivan-tymoshenko and
leorossi
August 12, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #94, which threaded
--versioninto the image build. Omitting--versionstill failed silently: the build got noPLT_DEPLOYMENT_ID, so the client assets carried no?dpl, and ICC correctly refused to pin a version that was not built with its own id. The app deployed and ran and nothing errored, query routing was simply absent.The version is now generated when the profile enables skew protection and no
--versionis given. It has to be minted before the image build, since the id is baked into the assets, so the flag is read from the profile rather than asked of the cluster.