Repository navigation
feat: add --skew flag and keep a single workload without it - #97
Merged
Merged
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
changed the title
marcopiraccini
marked this pull request as ready for review
August 13, 2026 11:35
ivan-tymoshenko
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
desk deploynamed the workload after the image tag when no--versionwas given, and the tag is aDate.now()value, so every deploy created a new Deployment instead of replacing the previous one. Nothing removed the old one either: expiry is skew-protection machinery, which ICC leaves off when the feature is disabled.--skewnow selects the shape, and naming a--versionimplies it. With it, each version is its own workload, ICC manages routing and expiry, and a version is generated before the build when none is named so it can be baked in asPLT_DEPLOYMENT_ID. Without it, the workload keeps the name{app}, each deploy rolls it over in place, anddeskwrites the HTTPRoute itself.Replaces the profile lookup from #95, which inferred the mode from
skew_protection.enable: the flag does not assume the profile matches the cluster being deployed to (which makes sense now that sp can be enabled per-app).Companion to platformatic/icc-3#989. Note that
profiles/development.yamlalso carries an unrelated edit commenting out the workflow service.