Clean up code

phpunit.xml.dist

@@ -4,11 +4,10 @@
     xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
     bootstrap="vendor/autoload.php"
     colors="true">
-    <coverage processUncoveredFiles="true">
-        <include>
-            <directory suffix=".php">./src</directory>
-        </include>
-    </coverage>
+
+    <extensions>
+        <bootstrap class="LaminasIntegrationTest\Db\Extension\ListenerExtension" />
+    </extensions>
 
     <testsuites>
         <testsuite name="unit test">
@@ -19,9 +18,6 @@
         </testsuite>
     </testsuites>
 
-    <listeners>
-        <listener class="LaminasIntegrationTest\Db\IntegrationTestListener" file="./test/integration/IntegrationTestListener.php"/>
-    </listeners>
 
     <php>
         <!-- Note: the following is a FULL list of ALL POSSIBLE constants

src/Adapter/AdapterAbstractServiceFactory.php

@@ -52,7 +52,6 @@ public function canCreateServiceWithName(ServiceLocatorInterface $serviceLocator
      * Create a DB adapter
      *
      * @param  string $requestedName
-     * @param  array $options
      * @return Adapter
      */
     public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null)

src/Adapter/AdapterServiceFactory.php

@@ -12,7 +12,6 @@ class AdapterServiceFactory implements FactoryInterface
      * Create db adapter service
      *
      * @param string $requestedName
-     * @param array $options
      * @return Adapter
      */
     public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null)

src/Adapter/Driver/AbstractConnection.php

@@ -94,7 +94,6 @@ public function inTransaction()
     }
 
     /**
-     * @param  array $connectionParameters
      * @return $this Provides a fluent interface
      */
     public function setConnectionParameters(array $connectionParameters)

src/Adapter/Driver/Mysqli/Mysqli.php

@@ -35,7 +35,6 @@ class Mysqli implements DriverInterface, Profiler\ProfilerAwareInterface
      * Constructor
      *
      * @param array|Connection|\mysqli $connection
-     * @param array $options
      */
     public function __construct(
         $connection,

src/Adapter/Driver/Oci8/Oci8.php

@@ -39,7 +39,6 @@ class Oci8 implements DriverInterface, Profiler\ProfilerAwareInterface
 
     /**
      * @param array|Connection|\oci8 $connection
-     * @param array $options
      * @param string $features
      */
     public function __construct(

src/Adapter/Driver/Oci8/Statement.php

@@ -314,8 +314,8 @@ protected function bindParametersFromContainer()
      */
     public function __clone()
     {
-        $this->isPrepared      = false;
-        $this->resource        = null;
+        $this->isPrepared = false;
+        $this->resource   = null;
         if ($this->parameterContainer) {
             $this->parameterContainer = clone $this->parameterContainer;
         }

src/Adapter/Driver/Pdo/Connection.php

@@ -4,7 +4,7 @@
 
 use Laminas\Db\Adapter\Driver\AbstractConnection;
 use Laminas\Db\Adapter\Exception;
-use Laminas\Db\Adapter\Exception\RunTimeException;
+use Laminas\Db\Adapter\Exception\RuntimeException;
 use PDOException;
 use PDOStatement;
 
@@ -84,7 +84,7 @@ public function setConnectionParameters(array $connectionParameters)
     /**
      * Get the dsn string for this connection
      *
-     * @throws RunTimeException
+     * @throws RuntimeException
      * @return string
      */
     public function getDsn()

src/Adapter/Driver/Sqlsrv/Statement.php

@@ -169,7 +169,6 @@ public function getSql()
 
     /**
      * @param string $sql
-     * @param array $options
      * @return $this Provides a fluent interface
      * @throws Exception\RuntimeException
      */
@@ -270,17 +269,11 @@ protected function bindParametersFromContainer()
         }
     }
 
-    /**
-     * @param array $prepareParams
-     */
     public function setPrepareParams(array $prepareParams)
     {
         $this->prepareParams = $prepareParams;
     }
 
-    /**
-     * @param array $prepareOptions
-     */
     public function setPrepareOptions(array $prepareOptions)
     {
         $this->prepareOptions = $prepareOptions;

src/Adapter/ParameterContainer.php

@@ -61,8 +61,6 @@ class ParameterContainer implements Iterator, ArrayAccess, Countable
 
     /**
      * Constructor
-     *
-     * @param array $data
      */
     public function __construct(array $data = [])
     {
@@ -194,7 +192,6 @@ public function offsetUnset($name)
     /**
      * Set from array
      *
-     * @param  array $data
      * @return $this Provides a fluent interface
      */
     public function setFromArray(array $data)

src/Adapter/Platform/PlatformInterface.php

@@ -80,7 +80,6 @@ public function getIdentifierSeparator();
      * Quote identifier in fragment
      *
      * @param  string $identifier
-     * @param  array $additionalSafeWords
      * @return string
      */
     public function quoteIdentifierInFragment($identifier, array $additionalSafeWords = []);

src/Metadata/Object/AbstractTableObject.php

@@ -35,8 +35,6 @@ public function __construct($name)
 
     /**
      * Set columns
-     *
-     * @param array $columns
      */
     public function setColumns(array $columns)
     {

src/Metadata/Object/ColumnObject.php

@@ -308,7 +308,6 @@ public function getErratas()
     }
 
     /**
-     * @param array $erratas
      * @return $this Provides a fluent interface
      */
     public function setErratas(array $erratas)

src/RowGateway/AbstractRowGateway.php

@@ -74,7 +74,6 @@ public function initialize()
     /**
      * Populate Data
      *
-     * @param  array $rowData
      * @param  bool  $rowExistsInDatabase
      * @return $this Provides a fluent interface
      */

src/RowGateway/Feature/FeatureSet.php

@@ -20,9 +20,6 @@ class FeatureSet
     /** @var array */
     protected $magicSpecifications = [];
 
-    /**
-     * @param array $features
-     */
     public function __construct(array $features = [])
     {
         if ($features) {
@@ -59,7 +56,6 @@ public function getFeatureByClassName($featureClassName)
     }
 
     /**
-     * @param array $features
      * @return $this Provides a fluent interface
      */
     public function addFeatures(array $features)

src/Sql/Ddl/Column/Column.php

@@ -98,7 +98,6 @@ public function getDefault()
     }
 
     /**
-     * @param  array $options
      * @return $this Provides a fluent interface
      */
     public function setOptions(array $options)

src/Sql/Ddl/Index/Index.php

@@ -18,7 +18,6 @@ class Index extends AbstractIndex
     /**
      * @param  string|array|null $columns
      * @param  null|string $name
-     * @param array $lengths
      */
     public function __construct($columns, $name = null, array $lengths = [])
     {

src/Sql/Expression.php

@@ -70,7 +70,6 @@ public function getParameters(): float|array|int|string|bool
     }
 
     /**
-     * @return array
      * @throws Exception\RuntimeException
      */
     public function getExpressionData(): array

src/Sql/Insert.php

@@ -75,7 +75,6 @@ public function into($table)
     /**
      * Specify columns
      *
-     * @param  array $columns
      * @return $this Provides a fluent interface
      */
     public function columns(array $columns)
@@ -134,7 +133,6 @@ public function values($values, $flag = self::VALUES_SET)
      *
      * @link http://stackoverflow.com/questions/173400/how-to-check-if-php-array-is-associative-or-sequential
      *
-     * @param array $array
      * @return bool
      */
     private function isAssocativeArray(array $array)

src/Sql/Select.php

@@ -120,7 +120,6 @@ class Select extends AbstractPreparableSql
     /** @var null|string|Expression */
     protected $quantifier;
 
-    /** @var array */
     protected array $columns = [self::SQL_STAR];
 
     /** @var Join[] */
@@ -226,7 +225,6 @@ public function quantifier($quantifier)
      *     key string will be use as alias,
      *     value can be string or Expression objects
      *
-     * @param  array $columns
      * @param  bool  $prefixColumnsWithTable
      * @return $this Provides a fluent interface
      */

src/TableGateway/Feature/FeatureSet.php

@@ -57,7 +57,6 @@ public function getFeatureByClassName($featureClassName)
     }
 
     /**
-     * @param array $features
      * @return $this Provides a fluent interface
      */
     public function addFeatures(array $features)

test/integration/Adapter/Driver/Pdo/Mysql/QueryTest.php

@@ -2,7 +2,6 @@
 
 namespace LaminasIntegrationTest\Db\Adapter\Driver\Pdo\Mysql;
 
-use Laminas\Db\Adapter\Adapter;
 use Laminas\Db\Adapter\Driver\Pdo\Result as PdoResult;
 use Laminas\Db\Adapter\Exception\RuntimeException;
 use Laminas\Db\ResultSet\ResultSet;

test/integration/Adapter/Driver/Pdo/Mysql/TableGatewayTest.php

@@ -65,6 +65,7 @@ public function testInsert()
     /**
      * @see https://github.com/zendframework/zend-db/issues/35
      * @see https://github.com/zendframework/zend-db/pull/178
+     *
      * @return mixed
      */
     public function testInsertWithExtendedCharsetFieldName()

test/integration/Extension/IntegrationTestStartedListener.php

@@ -0,0 +1,48 @@
+<?php
+
+namespace LaminasIntegrationTest\Db\Extension;
+
+use LaminasIntegrationTest\Db\Platform\FixtureLoader;
+use LaminasIntegrationTest\Db\Platform\MysqlFixtureLoader;
+use LaminasIntegrationTest\Db\Platform\PgsqlFixtureLoader;
+use LaminasIntegrationTest\Db\Platform\SqlServerFixtureLoader;
+use PHPUnit\Event\TestSuite\Started;
+use PHPUnit\Event\TestSuite\StartedSubscriber;
+
+use function getenv;
+use function printf;
+
+final class IntegrationTestStartedListener implements StartedSubscriber
+{
+    /** @var FixtureLoader[] */
+    private $fixtureLoaders = [];
+
+    public function notify(Started $event): void
+    {
+        if ($event->testSuite()->name() !== 'integration test') {
+            return;
+        }
+
+        if (getenv('TESTS_LAMINAS_DB_ADAPTER_DRIVER_MYSQL')) {
+            $this->fixtureLoaders[] = new MysqlFixtureLoader();
+        }
+
+        if (getenv('TESTS_LAMINAS_DB_ADAPTER_DRIVER_PGSQL')) {
+            $this->fixtureLoaders[] = new PgsqlFixtureLoader();
+        }
+
+        if (getenv('TESTS_LAMINAS_DB_ADAPTER_DRIVER_SQLSRV')) {
+            $this->fixtureLoaders[] = new SqlServerFixtureLoader();
+        }
+
+        if (empty($this->fixtureLoaders)) {
+            return;
+        }
+
+        printf("\nIntegration test started.\n");
+
+        foreach ($this->fixtureLoaders as $fixtureLoader) {
+            $fixtureLoader->createDatabase();
+        }
+    }
+}

test/integration/Extension/IntegrationTestStoppedListener.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace LaminasIntegrationTest\Db\Extension;
+
+use LaminasIntegrationTest\Db\Platform\FixtureLoader;
+use PHPUnit\Event\TestSuite\Finished;
+use PHPUnit\Event\TestSuite\FinishedSubscriber;
+
+use function printf;
+
+final class IntegrationTestStoppedListener implements FinishedSubscriber
+{
+    /** @var FixtureLoader[] */
+    private $fixtureLoaders = [];
+
+    public function notify(Finished $event): void
+    {
+        if (
+            $event->testSuite()->name() !== 'integration test'
+            || empty($this->fixtureLoaders)
+        ) {
+            return;
+        }
+
+        printf("\nIntegration test ended.\n");
+
+        foreach ($this->fixtureLoaders as $fixtureLoader) {
+            $fixtureLoader->dropDatabase();
+        }
+    }
+}

test/integration/Extension/ListenerExtension.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace LaminasIntegrationTest\Db\Extension;
+
+use PHPUnit\Runner\Extension\Extension;
+use PHPUnit\Runner\Extension\Facade;
+use PHPUnit\Runner\Extension\ParameterCollection;
+use PHPUnit\TextUI\Configuration\Configuration;
+
+final class ListenerExtension implements Extension
+{
+    public function bootstrap(
+        Configuration $configuration,
+        Facade $facade,
+        ParameterCollection $parameters
+    ): void {
+        $facade->registerSubscribers(
+            new IntegrationTestStartedListener(),
+            new IntegrationTestStoppedListener(),
+        );
+    }
+}

test/unit/Metadata/Source/OracleMetadataTest.php

@@ -40,7 +40,6 @@ protected function setUp(): void
 
     /**
      * @dataProvider constraintDataProvider
-     * @param array $constraintData
      */
     public function testGetConstraints(array $constraintData)
     {