Clean up code - #33
Merged
Merged
Conversation
This change refactors some of the test code to support PHPUnit's most recent iteration of its event system. The previous iteration worked for earlier versions, but there was a newer version release in PHPUnit 10.0.7.
A series of small fixes thanks to the wonderful PHP CS_Fixer Signed-off-by: Matthew Setter <matthew@matthewsetter.com>
tyrsson
approved these changes
Mar 27, 2025
tyrsson
left a comment
tyrsson
left a comment
Member
There was a problem hiding this comment.
Approved, but will wait to hear your response about updating the factories before we merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a series of small fixes thanks to the wonderful PHP CS_Fixer.
This depends on #32, as it was branched off of that branch.