Add a Docker configuration - #30
Merged
Merged
Conversation
This change adds the initial Docker setup, providing an environment where the tests can be run, regardless of the user's operating system. It provides three services; one for PHP, one for MySQL, and one for PostgreSQL. The PHP environment has all of the dependencies and extensions required to interact with MySQL, PostgreSQL, and SQLite, along with any required binaries. It also updates PHPUnit's configuration, where required, to sync with that configuration. The change also removes the Vagrantfile as it's no longer required. Signed-off-by: Matthew Setter <matthew@matthewsetter.com>
settermjd
force-pushed
the
add-docker-configuration
branch
from
March 19, 2025 06:18
0ce7bef to
c806991
Compare
settermjd
marked this pull request as draft
March 19, 2025 06:51
This removes the Composer setup from the startup script, replacing it with mounting the files from the local filesystem as volume mounts. It also exposes the database ports so that they can be connected to locally, should the need arise, using database clients. It adds health checks to help ensure a robust service configuration. And, it loads SQL scripts to initialise the MySQL and PostgreSQL databases. Signed-off-by: Matthew Setter <matthew@matthewsetter.com>
settermjd
force-pushed
the
add-docker-configuration
branch
from
March 19, 2025 07:04
f60e2bf to
f15189d
Compare
settermjd
marked this pull request as ready for review
March 19, 2025 07:07
Collaborator
Author
|
I've not run the unit tests yet, but of the integration tests, I get the following results: Tests: 22, Assertions: 0, Errors: 3, Warnings: 2, PHPUnit Deprecations: 15, Skipped: 22. |
Collaborator
Author
|
For the unit tests ( docker compose exec php composer check
> phpcs
.........EE..........E.........................E............ 60 / 381 (16%)
....................E.......E................E.....E........ 120 / 381 (31%)
.........E.........E..E..........E...E.........EE..E........ 180 / 381 (47%)
E..........E....E....E..E................................... 240 / 381 (63%)
............................................................ 300 / 381 (79%)
............................................................ 360 / 381 (94%)
....
Fatal error: Trait "PHPUnit\Framework\TestListenerDefaultImplementation" not found in /var/www/html/test/integration/IntegrationTestListener.php on line 17 |
tyrsson
approved these changes
Mar 20, 2025
tyrsson
left a comment
tyrsson
left a comment
Member
There was a problem hiding this comment.
Looks really good, now to just migrate it once the satellites are ready. Should be simple enough to split. Then its a matter of updating the test :(
| ``` | ||
|
|
||
| If you see three containers listed, then they're all running, and you are ready to run the test suite. | ||
| So, copy `phpunit.xml.dist` to `phpunit.xml`, and change the following environment variable to "true" to enable the three databases: |
Member
There was a problem hiding this comment.
Is this line suppose to remain in docs?
Member
There was a problem hiding this comment.
Line 71 is the line I was referencing there.
Member
There was a problem hiding this comment.
line 23 is most likely why you are getting the listener error.
Member
There was a problem hiding this comment.
Although, I'm not sure why unless this was affected by the huge amount of changes to the event system in the newer versions of Phpunit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Docker (Compose) setup and deprecates the Vagrantfile as it's no longer required.
The configuration provides an environment where the tests can be run, regardless of the user's operating system. The Compose configuration provides three services; one for PHP, one for MySQL, and one for PostgreSQL. The PHP environment has all of the dependencies and extensions required to interact with MySQL, PostgreSQL, and SQLite, along with any required binaries. It also updates PHPUnit's configuration, where required, to sync with that configuration. The change also updates README.md to reflect the changes.