fix(mobile): restore missing distance-transform diagonal - #644
Merged
petercorke merged 1 commit intoAug 26, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 143 143
Lines 14035 14035
=====================================
Misses 14035 14035 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to RTB!
Summary
DistanceTransformPlanner.next()currently has seven neighbour offsets plus[0, 0], leaving thedy=-1, dx=+1diagonal unavailable during path extraction.The Euclidean distance transform itself is 8-connected, so this makes path extraction asymmetric with the cost map.
This replaces the self-offset with the missing diagonal
[-1, 1]and adds a regression test on an interior 5x5 grid where that move is the unique shortest next step.Related issue
Fixes #503
Checklist
type: description)pytest)X | Y,list[X], notUnion/Optional/List)