Fail closed when receipt verification is unavailable

permission_protocol/client.py

@@ -82,17 +82,13 @@ def authorize(
 
     def verify(self, *, receipt_id: str) -> Receipt:
         receipt = self.get_receipt(receipt_id)
-        verification_data: Dict[str, Any] = {}
-        try:
-            verification_data = self._request(
-                "POST",
-                "/api/v1/receipts/verify",
-                json={"receiptId": receipt_id, "failOnMissing": True},
-            )
-        except APIError:
-            verification_data = {}
+        verification_data = self._request(
+            "POST",
+            "/api/v1/receipts/verify",
+            json={"receiptId": receipt_id, "failOnMissing": True},
+        )
 
-        valid = bool(verification_data.get("valid", receipt.valid))
+        valid = bool(verification_data.get("valid", False))
         receipt_payload = verification_data.get("receipt")
         if receipt_payload:
             parsed = Receipt.from_dict(receipt_payload, default_url=receipt.url)

tests/test_client.py

@@ -3,7 +3,7 @@
 from unittest.mock import patch
 
 from permission_protocol.client import PermissionProtocolClient
-from permission_protocol.exceptions import PermissionDenied, PermissionTimeout
+from permission_protocol.exceptions import APIError, PermissionDenied, PermissionTimeout
 from permission_protocol.models import Config, Receipt
 
 
@@ -103,6 +103,44 @@ def fake_request(method, path, **kwargs):
         receipt = self.client.verify(receipt_id="pp_r_4")
         self.assertTrue(receipt.valid)
 
+    def test_verify_fails_closed_when_verification_request_fails(self):
+        self.client.get_receipt = lambda receipt_id: Receipt(
+            id=receipt_id,
+            status="APPROVED",
+            action="deploy",
+            resource="svc",
+            actor="bot",
+            valid=True,
+        )
+
+        def fake_request(method, path, **kwargs):
+            raise APIError("verification service unavailable")
+
+        self.client._request = fake_request
+
+        with self.assertRaises(APIError):
+            self.client.verify(receipt_id="pp_r_5")
+
+    def test_verify_does_not_trust_fetched_receipt_valid_flag(self):
+        self.client.get_receipt = lambda receipt_id: Receipt(
+            id=receipt_id,
+            status="APPROVED",
+            action="deploy",
+            resource="svc",
+            actor="bot",
+            valid=True,
+        )
+
+        def fake_request(method, path, **kwargs):
+            self.assertEqual(method, "POST")
+            self.assertEqual(path, "/api/v1/receipts/verify")
+            return {}
+
+        self.client._request = fake_request
+
+        receipt = self.client.verify(receipt_id="pp_r_6")
+        self.assertFalse(receipt.valid)
+
 
 if __name__ == "__main__":
     unittest.main()