Fail closed when receipt verification is unavailable#1
Open
manuelsampedro1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify()require an authoritative/api/v1/receipts/verifyresponse instead of swallowing API errorsvalidfields in verification responses tofalseWhy
verify()fetched a receipt first and then swallowedAPIErrorfrom the verification endpoint. If the fetched receipt object already hadvalid=True, callers could receive a verified-looking receipt even though the signature/scope verification call failed. Verification should fail closed.Validation
python3 -m pytest -qgit diff --checkRelated to permission-protocol/deploy-gate#36 / permission-protocol/deploy-gate#49.