Skip to content

⚡ Optimize Array Creation in Hologram Component #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavan721 wants to merge 1 commit into
base: feat/jarvis-ai-interface-17926432446021056838
Choose a base branch
from
Open

⚡ Optimize Array Creation in Hologram Component #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/3d/Hologram.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ function ArcCore({ isSpeaking, isProcessing }: { isSpeaking: boolean; isProcessi
)
}

const COILS_ARRAY = Array.from({ length: 10 })

function ArcRings({ isSpeaking, isProcessing }: { isSpeaking: boolean; isProcessing: boolean }) {
const groupRef = useRef<THREE.Group>(null)

Expand All @@ -62,7 +64,7 @@ function ArcRings({ isSpeaking, isProcessing }: { isSpeaking: boolean; isProcess
</Torus>

{/* Segmented coils */}
{Array.from({ length: 10 }).map((_, i) => (
{COILS_ARRAY.map((_, i) => (
<group key={i} rotation={[0, 0, (i / 10) * Math.PI * 2]}>
<Cylinder args={[0.05, 0.05, 0.6, 8]} position={[0, 1.5, 0]} rotation={[0, 0, 0]}>
<meshStandardMaterial color="#444" metalness={0.8} roughness={0.2} />
Expand All @@ -77,6 +79,8 @@ function ArcRings({ isSpeaking, isProcessing }: { isSpeaking: boolean; isProcess
)
}

const STRUTS_ARRAY = Array.from({ length: 3 })

function ArcCasing() {
const groupRef = useRef<THREE.Group>(null)

Expand All @@ -94,7 +98,7 @@ function ArcCasing() {
</Cylinder>

{/* Casing details / struts */}
{Array.from({ length: 3 }).map((_, i) => (
{STRUTS_ARRAY.map((_, i) => (
<mesh key={i} rotation={[0, 0, (i / 3) * Math.PI * 2]} position={[0, 0, 0.1]}>
<boxGeometry args={[0.2, 5.2, 0.1]} />
<meshStandardMaterial color="#333" metalness={0.8} roughness={0.5} />
Expand Down