Capture Safari images and clarify iOS setup - #13
Merged
Merged
Conversation
Signed-off-by: Patrick Schiller <p@trickschiller.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Safari captures now include up to 12 relevant article images. The Share Extension downloads valid public image responses, saves them under the clip’s local asset directory, links them relatively from the Markdown document, and records image metadata in the index entry.
The configuration screen now says: “Weave the web into durable Markdown in your own GitHub repository.” The iOS and German/English project documentation were updated accordingly.
Why
Safari previously sent only page text. The saved Heise clip therefore had no image assets despite SourceBraid’s durable-archive contract.
Privacy and permissions
No new user permissions, credentials, or external services were introduced. Image requests use the public URLs Safari already exposes, accept image content only, limit each image to 8 MB and a capture to 25 MB, and store successful assets directly in the configured private repository.
Validation
node --test tests/capture-utils.test.jspython3 -m unittest discover -s tests -p 'test_*.py'\n-python3 scripts/validate_ios_release.py\n-xcodebuild -project SourceBraid.xcodeproj -scheme SourceBraid -destination 'platform=iOS Simulator,id=F8D5E279-4FAF-4DA0-AE17-4903706F4E7C' CODE_SIGNING_ALLOWED=NO test