Fix Safari share preprocessing - #12
Merged
Merged
Conversation
Signed-off-by: Patrick Schiller <p@trickschiller.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Safari could open the Share Extension but it never received the page payload, so saving failed before GitHub access.
Implementation
Export
ExtensionPreprocessingJSas the global object Safari invokes, rather than as a constructor whoserunmethod only existed on its prototype. Added a regression test that evaluates the bundled script and verifies URL, title, selected text, and article text.Privacy and permissions
No permissions, network endpoints, storage formats, or credential handling changed.
Checks
python3 -m unittest discover -s tests -p 'test_ios*.py'\n-xcodebuild -project SourceBraid.xcodeproj -scheme SourceBraid -sdk iphonesimulator -destination 'generic/platform=iOS Simulator' CODE_SIGNING_ALLOWED=NO build