fix(api): secure request workflow identities - #28
Merged
Merged
Conversation
Signed-off-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
employeeId/actorIdin request bodies and perform privileged transitions (approvals, HR confirms) that materialize payroll-relevant TimeEntries.Description
@ApiBearerAuth()and@UseGuards(JwtAuthGuard), and derive actor identity from@CurrentUser()rather than request body fields.employeeIdwithuser.idwhen creating requests.RequestsService: addassertApprover(request, actorId),visibilityWhere(actorId), andassertCanView(request, actorId)to enforce that Managers may only transition assigned requests, substitutes may act only for their assigned requests, requesters may cancel their own requests, and HR admins retain org-wide visibility.actorIdargument tolist/getById/eventsand applyingvisibilityWhere.apps/api/openapi.json) to declare bearer security on the protected routes.Testing
pnpm nx run api:typecheckandpnpm nx run api:build, both succeeded.pnpm nx run api:lintcompleted with pre-existing warnings and no errors, andpnpm generate:apiregeneratedapps/api/openapi.jsonsuccessfully.pnpm nx run api-e2e:typecheckwhich succeeded, whilepnpm nx run api-e2e:e2ecould not complete because the test global setup could not connect to a local PostgreSQL instance, so full e2e execution was not possible in this environment.Codex Task