fix(api): secure request workflows against identity impersonation - #27
Closed
patrickschiller wants to merge 1 commit into
Closed
patrickschiller wants to merge 1 commit into
patrickschiller wants to merge 1 commit into
Conversation
Signed-off-by: Codex <codex@openai.com>
patrickschiller
deleted the
codex/fix-unauthenticated-access-to-request-apis
branch
August 27, 2026 13:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
employeeId/actorIdand lacked authentication, allowing unauthenticated enumeration and privileged-actor impersonation.Description
@ApiBearerAuth()and@UseGuards(JwtAuthGuard)toRequestsControllerand protect the employee directory by addingJwtAuthGuardtoEmployeesController.CreateRequestDto.employeeIdandTransitionDto.actorIdby deriving the acting employee from the@CurrentUser()JWT principal in every requests controller handler and forwarding that authenticateduser.idto the service.RequestsServiceby adding object-level visibility and authorization helpers (visibilityWhere,assertCanView, andassertApprover) and enforcing that managers may only act on requests assigned to them whileHRAdminretains org-wide visibility.apps/api/openapi.json/ generated client accordingly.materializeTimeAdjustment) while ensuring all transitions require a bound authenticated principal.Testing
pnpm nx run api:typecheckwhich completed successfully.pnpm nx run api:buildwhich completed successfully.pnpm nx run api:lintwhich completed successfully and reported only pre-existing warnings (6 warnings).pnpm generate:apiand ranpnpm nx format:checkfor the modified files, both of which completed successfully.fix(api): secure request workflows(DCO-signed); an attempt to emit PR metadata via the localmake_prhelper failed due to an environment module mismatch but does not affect the code changes or the automated checks above.Codex Task