Make the Play listing publish manual-only - #806
Merged
Merged
Conversation
A merge to `main` no longer touches Google Play in any way. `android.yml` already uploaded no AAB on a main push (PR #794); `play-listings.yml` was the last thing that did — a main push touching `fastlane/metadata/android/**` published the changed locales to the store as a side effect of the promotion. Drop that push trigger. Listing text still lands in the repo on the normal feature -> dev -> staging -> main flow and is still validated on the way in (the PR gate runs the completeness/character-limit tests unchanged), but it reaches the store only when someone runs the publish on purpose: the manual workflow_dispatch (dry-run / check-permissions / publish) or `.github/scripts/publish_listings.py` locally. Also make MODE fall back to the read-only `dry-run` instead of `publish`, so a mode that somehow arrives empty sends nothing to Play. No new code path to test: the change is workflow triggers plus docs, and the 135 publish_listings unit tests pass unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XNDpfHeom9W1c7spiGxP6H
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #806 +/- ##
=========================================
Coverage 42.64% 42.64%
Complexity 226 226
=========================================
Files 267 267
Lines 32068 32068
Branches 3664 3664
=========================================
Hits 13675 13675
Misses 18132 18132
Partials 261 261
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A merge to
mainno longer touches Google Play in any way.android.ymlalready uploaded no AAB on amainpush (#794) —play-listings.ymlwas the last Play-touching thing left on that path: amainpush touchingfastlane/metadata/android/**published the changed locales to the store as a side effect of the promotion. This drops that trigger.After this
dev/staging/maindry-run(default, read-only) /check-permissions/publishpython .github/scripts/publish_listings.pylocallySo
staging → mainnow cuts theandroid-v<x.y.z>tag + GitHub Release and thedesktop-v*release, and stops there. Both the app binary and the store copy are shipped deliberately, by hand.Also:
MODEnow falls back to the read-onlydry-runrather thanpublish, so a mode that somehow arrives empty sends nothing to Play.Tests
No new code path — the change is workflow triggers plus docs. The 135
publish_listingsunit tests pass unchanged (python -m unittest discover -s .github/scripts), and the workflow still parses with onlypull_request+workflow_dispatchtriggers.Docs updated:
docs/release-pipeline.md(branch lifecycle + Store listings section) anddocs/store-listings.md(Publishing section).🤖 Generated with Claude Code
https://claude.ai/code/session_01XNDpfHeom9W1c7spiGxP6H