Conversation
A merge to `main` no longer touches Google Play in any way. `android.yml` already uploaded no AAB on a main push (PR #794); `play-listings.yml` was the last thing that did — a main push touching `fastlane/metadata/android/**` published the changed locales to the store as a side effect of the promotion. Drop that push trigger. Listing text still lands in the repo on the normal feature -> dev -> staging -> main flow and is still validated on the way in (the PR gate runs the completeness/character-limit tests unchanged), but it reaches the store only when someone runs the publish on purpose: the manual workflow_dispatch (dry-run / check-permissions / publish) or `.github/scripts/publish_listings.py` locally. Also make MODE fall back to the read-only `dry-run` instead of `publish`, so a mode that somehow arrives empty sends nothing to Play. No new code path to test: the change is workflow triggers plus docs, and the 135 publish_listings unit tests pass unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XNDpfHeom9W1c7spiGxP6H
Make the Play listing publish manual-only
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #807 +/- ##
==========================================
Coverage 42.64% 42.64%
Complexity 226 226
==========================================
Files 267 267
Lines 32068 32068
Branches 3664 3664
==========================================
Hits 13675 13675
Misses 18132 18132
Partials 261 261
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this promotion
One PR since
android-dev.1221:push: branches: [main]trigger fromplay-listings.yml, so astaging → mainmerge now reaches Google Play in no way at all:android.ymlalready uploaded no AAB there (CI: stop publishing to Play production on staging → main merges #794), and store-listing text was the last thing that still published as a side effect of the promotion. Listing copy is still validated on every PR that touches it, and now ships only on a deliberateworkflow_dispatchrun (dry-rundefault /check-permissions/publish) or by running.github/scripts/publish_listings.pylocally. Docs updated indocs/release-pipeline.mdanddocs/store-listings.md.What merging this does
Cuts the usual dev build — unchanged by #806:
android-dev.<run#>GitHub prerelease + the signed AAB and R8 mapping to the Play internal track, with Claude's semver + release notes.desktop-dev.<run#>prerelease for the Tauri desktop bundles.The diff since
android-v0.149touches 574 files underft8af/, soandroid_changedis true and the Android release will be cut normally (this promotion's own change is workflow/docs only).🤖 Generated with Claude Code
https://claude.ai/code/session_01XNDpfHeom9W1c7spiGxP6H