-
Notifications
You must be signed in to change notification settings - Fork 91
[api] Serve full system version from /v1/version
#10839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: system-version-api
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,6 +34,17 @@ ptime -m cargo run --locked --release --bin omicron-package -- \ | |
| -t test target create -p dev | ||
| ptime -m cargo run --locked --release --bin omicron-package -- \ | ||
| -t test package | ||
|
|
||
| # Exercise the same stamped-zone path used by releng while giving the deploy | ||
| # job a distinctive value to verify through Nexus. `install` reads packages | ||
| # from their unversioned output paths, so replace the Nexus archive with the | ||
| # stamped output before assembling package.tar.gz. | ||
| DEPLOY_SYSTEM_VERSION="0.0.0-deploy-test" | ||
| ptime -m cargo run --locked --release --bin omicron-package -- \ | ||
| --target test stamp nexus "$DEPLOY_SYSTEM_VERSION" | ||
| cp out/versioned/nexus.tar.gz out/nexus.tar.gz | ||
| printf '%s\n' "$DEPLOY_SYSTEM_VERSION" >out/deploy-system-version | ||
|
|
||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My tentative understanding is that it should be ok to stamp here because the only thing that reads this archive is the |
||
| mapfile -t packages \ | ||
| < <(cargo run --locked --release --bin omicron-package -- -t test list-outputs) | ||
|
|
||
|
|
@@ -55,6 +66,7 @@ mkdir tests | |
|
|
||
| files=( | ||
| .github/buildomat/ci-env.sh | ||
| out/deploy-system-version | ||
| out/target/test | ||
| out/npuzone/* | ||
| package-manifest.toml | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This passes, so the whole thing works in a basic sense. Neat.