[api] Serve full system version from /v1/version#10839
Draft
david-crespo wants to merge 2 commits into
Draft
Conversation
david-crespo
commented
Jul 16, 2026
| --target test stamp nexus "$DEPLOY_SYSTEM_VERSION" | ||
| cp out/versioned/nexus.tar.gz out/nexus.tar.gz | ||
| printf '%s\n' "$DEPLOY_SYSTEM_VERSION" >out/deploy-system-version | ||
|
|
Contributor
Author
There was a problem hiding this comment.
My tentative understanding is that it should be ok to stamp here because the only thing that reads this archive is the helios / deploy CI job, i.e., this shouldn't conflict with any actual release stamping business.
Read the full stamped version string (N.P.C-pre+gitHHHH) from a well-known path inside the deployed zone (/var/oxide/system-version), falling back to the compile-time SYSTEM_VERSION core when absent (dev/test, unstamped packages). /v1/version now serves this via omicron_common::system_version().
david-crespo
force-pushed
the
serve-zone-version
branch
from
July 16, 2026 21:16
054485e to
326de2c
Compare
david-crespo
force-pushed
the
serve-zone-version
branch
from
July 16, 2026 21:17
326de2c to
f3118d4
Compare
david-crespo
commented
Jul 17, 2026
| echo "$VERSION_RESPONSE" | ||
| exit 1 | ||
| fi | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This passes, so the whole thing works in a basic sense. Neat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on #10250. Temporarily pins
omicron-zone-packageto oxidecomputer/omicron-package#79 so we can test the file in the Nexus zone containing the full stamped version. At Nexus startup we read the version from that file into memory so future hits to the endpoint are cheap (because we want to serve it to unauthenticated users). See RFD 708.