Repository navigation
feat(web): drag files and chat links onto right-panel panes - #249
Merged
Merged
Conversation
Thread transfer impact
This comment will update automatically after the next completed run. |
orbitingflea
force-pushed
the
feat/drag-link-to-panel
branch
from
November 22, 2026 02:15
ac51a4b to
dd58207
Compare
|
This PR changes the test suite by +21 test cases (browser +6, unit +15, server 0). Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing. |
…dropped on Dragging a Files row or a chat link (file, pull request, issue, thread, board, Dashboard or web link) onto a right-panel pane opens it there. A drop on a tab strip opens it at that slot, and the outer thirds of a single pane split the panel with the link on that side, as a tab drag does. Each source keeps its own open; the panel places the surface that open activates. The composer @mention drop, also in a side chat inside the panel, and tab dragging are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
orbitingflea
force-pushed
the
feat/drag-link-to-panel
branch
from
November 22, 2026 03:05
dd58207 to
6a033d0
Compare
This was referenced Nov 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes Files-tree files and chat links draggable onto right-panel panes, so users can open them directly in a chosen pane, tab slot, or split.
改了什么行为
Behaviour change: yes, a web or desktop user who drags a Files-tree file or a supported chat link onto a right-panel pane opens it in that pane, at a tab-strip slot, or in a new split on the left or right third of a single pane.
board://, Dashboard, and web URLs (web URLs open in the preview browser).#42, commit, and web image or video URLs do not drag. Files@mention(side chats too), text, tab, and Mac or Windows file-chip drags stay unchanged. Clicks or keys cancel a slow open.Checks
Implementation details, checks, and screenshots
Implementation
apps/web/src/fork/rightPanelSplit/hold the drag marker (panelLinkDrag.ts), drop planning (linkDrop.logic.ts), drop target (PanelLinkDropScope.tsx), and source rules (linkSources.ts,chatAnchorLink.ts).keepExploreronopenFile(rightPanelStore.ts),data-right-panel-tab-idon tabs, andissueLinkTarget(openIssueLink.ts) shared by click and drag. The chat renderer passes its preview opener intochatAnchorLink.ts, which reads the opened tab and reports failures in fork code.fileChipPanelLinkholds the file-chip drop rule in the fork and needs only a thread and panel path, as clicks do.data-panel-link-dragappliespanelLinkDrag.css(pointer-events: none !important) to panel frames and the fixed desktop preview layer above the pane, overriding its inlinepointer-events: autoso drops reach the pane.Checks run
linkDrop.logic.test.ts), source rules (linkSources.test.ts), store tests, and file-tree mention tests (fileTreeDragMention.test.ts).RightPanelSplitView.browser.test.tsxcover real drags: an iframe pane, a preview-like layer with inlinepointer-events: auto, tab-strip slots, a side-chat mention drop, non-claiming targets, a slow open cancelled by a press, and a slow open placing its own tab when another open activates a tab first. Desktop Electron stays unchecked by hand, so only this Chromium test covers the new rule.@mentionin main and side-chat message boxes, a web link over an HTML iframe, unchanged tab dragging, and the ghost at phone width (361x662).Screenshots
Desktop. A chat file chip dropped on the right third split the panel.
Desktop. A ghost marker on a tab strip during a drag.
Desktop. A Files row dropped on a side chat's message box inside the panel added a mention.
Phone width. A ghost box over the panel during a drag.