Skip to content

feat(fork): turn the area right of the thread list into a work area of split panes - #216

Open
orbitingflea wants to merge 1 commit into
mainfrom
proto/fullscreen-panels
Open

orbitingflea wants to merge 1 commit into
mainfrom
proto/fullscreen-panels

Conversation

@orbitingflea

@orbitingflea orbitingflea commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

This pull request turns the area right of the thread list into split panes with Chat as a tab, and it is an experimental prototype that is not meant to merge.

Behaviour change

Behaviour change: yes, users of web and desktop builds of this branch see split panes instead of a chat beside a right panel.

  • Only a tab floating in the mini player is hidden, and it always returns when the mini player closes, Chat hides, or the client loses preview permission.
  • Preview: Toggle floats the tab, docks it back, or closes an empty New tab.
  • Diff: Toggle closes the Diff tab or reopens it.
  • The bottom terminal drawer is gone, so every terminal opens as a tab.
  • Cmd+J and Ctrl+J are removed from keybindings and now reach the shell.
  • Dragging a file or chat link into a pane opens or moves it at the drop spot.

Why

Invisible hidden tabs were hard to follow, so this change removes them, the terminal drawer, and the terminal toggle shortcut. It also rebases onto main to move PR #249 link drops onto panes and includes three review fixes.

Checks

  • The 558 fork unit tests, 146 related unit tests, and work-area browser tests pass.
  • Changed-file format, lint, knip, and typecheck pass. Browser tests that time out in parallel pass when run alone.
  • Real web app checks passed, and only browser tests cover drag and drop.

Undo

Revert the commit. There is no server, contract, or database change.

Design notes
  • The floating tab is the only tab outside a pane. A tab floats only when it closes while playing in the mini player. It returns when the player closes, the tab docks or reveals, Chat hides, or the client loses preview permission. The floating tab is never saved. A saved work-area layout that lists hidden tabs in the older hidden list on workArea loads with those tabs back in panes.
  • Every request to open the terminal drawer opens a terminal tab, and project scripts or Run reuse an idle tab. Server terminals without a tab appear as background tabs, and closed ones stay closed. The chat header drops the terminal button, top band, and New thread in project, and keeps Details on the right. The project name in the header is plain text, and the thread list's new-thread buttons stay.
  • Link drops target a tab strip slot, the outer quarter of any edge, or the middle, and they open through the click open origin. A click or key press before a slow drop finishes cancels the drop spot.
  • Dragging a tab to an edge splits the pane, and closing the last tab removes the pane. A tab menu has Move left, Move right, Move up, and Move down to move a tab to a neighbouring pane from the keyboard. Chat links show an open tab, split a lone pane right, or pick the nearest non-Chat pane. Automatic opens never cover Chat, reply, side-chat, or subagent tabs.
  • Each Replies sub-thread is a tab with its own draft. A Find step into a reply shows it in another pane if one fits and keeps focus in Chat. In the single-strip view, the reply shows, and the Find bar stays on top and keeps focus. A Find step to the main list shows Chat again. A quote jump shows the reply like a plain open. Same-project thread drags open a Chat tab. Modifier or middle clicks navigate like upstream.
  • Each right-panel record stores workArea and at most one unsaved floating tab. Store writes keep at least one Chat and a 360 px floor for message-box panes, and unfit saved layouts show as a single-pane strip. One table holds tab rules.
  • Review fixes treat a subagent page's child side-thread tab as its own thread, open the composer pull request chip beside its chat, and stop reusing pane ids after single-pane fallback. Fork code lives in apps/web/src/fork/ with hooks in 46 upstream files, in English only.

Known limits:

  • A browser tab from a chat or file link may appear briefly in another pane before it moves beside its source.
  • A floating tab that returns after a view change lands in the focused pane, not always its old pane.
  • A main-Chat open with no other source, such as a subagent click, may cover a side chat.
  • A side thread tool diff opens beside the main Chat.
  • Saved layouts with a side chat under 360 px show as a strip until the side chat moves or closes.
  • Linked-environment thread links open upstream's read-only view in a pane.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XL labels Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

This PR changes the test suite by +116 test cases (browser +17, unit +99, server 0).

New browser test files: apps/web/src/fork/subThreads/subThreadFind.browser.test.tsx, apps/web/src/fork/workArea/WorkArea.browser.test.tsx, apps/web/src/fork/workArea/changeRequestLink.browser.test.tsx.
Each browser test file costs CI seconds of module loading before its first test runs; a unit test costs milliseconds.

Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing.

@orbitingflea
orbitingflea force-pushed the proto/fullscreen-panels branch from 377fc32 to 547954f Compare November 20, 2026 00:43
@orbitingflea orbitingflea changed the title feat(fork): make the chat a tab of the maximized right panel feat(fork): turn the area right of the thread list into a work area of split panes Nov 20, 2026
@github-actions github-actions Bot added size:XXL and removed size:XL labels Nov 20, 2026
@orbitingflea
orbitingflea force-pushed the proto/fullscreen-panels branch 2 times, most recently from 05fe5d0 to 66e542e Compare November 20, 2026 02:26
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 33416f9.

This comment will update automatically after the next completed run.

@orbitingflea
orbitingflea force-pushed the proto/fullscreen-panels branch 11 times, most recently from 8805261 to 944aab0 Compare November 22, 2026 16:20
…f split panes

Everything right of the thread list is one work area of nested panes, and
the chat is one kind of tab in it. Dragging a tab onto an edge of a pane
splits that pane; closing a pane's last tab closes the pane. Dragging a
thread of the same project from the thread list into the area opens its
chat as another Chat tab, whose file links open that thread's files. The
last Chat tab cannot close. Each thread keeps its own layout in its
right-panel record, and the right panel's show, hide and maximize
controls are gone.

A tab opened from a chat or a linked file shows a tab already open, or
splits a lone pane to the right, or else lands in the nearest other pane,
preferring one not showing a Chat, looking right, left, down, then up.
A whiteboard chip in the composer and a board:// link in a chat show the
region on the Whiteboard and never open a file.

A pane holding a chat, reply or side-thread box is at least 360 px wide,
and automatic opens never cover a reply or side-thread tab. The chat
header loses its terminal button and the band above it, and its details
toggle sits at the right end of the pane's tab bar. A lone pane has a
Split right button that opens a New tab launcher beside it. A thread link
of the same project opens that thread as a Chat tab by the same rule; a
thread of another project or environment opens on its own page.
Subagents and side chats use upstream's side-thread tabs. Each Replies
sub-thread opens as its own tab with its own draft. A quote link shows
its reply tab; a Find step keeps the Find field and never covers its
chat. Both reuse the reply tab the last reveal opened until the user
takes it over.

The only tab in no pane is a browser or device tab that floats in the
mini player. Preview: Toggle, picture-in-picture and device Float move
it there; closing the player, Open in panel or Preview: Toggle again
puts it back, and so does any view that stops drawing the Chat that
holds the player. Preview: Toggle on an empty browser tab closes it.
Diff: Toggle closes the Diff tab when shown and opens it otherwise, so
Reopen Closed View sees the close.

There is no terminal drawer under the chat. A request to open the drawer
becomes a terminal tab in the PTY's own thread record, so scripts, chat
code-block Run and the setup banner keep working; server terminals with
no tab are adopted as background tabs, and a tab the user closed stays
closed while the server still lists it. Terminal: Toggle (Cmd/Ctrl+J) is
filtered out of the web client's keybindings and settings, so the key
reaches the shell; split, new and close act on the focused terminal tab.

Files tree rows and chat links (upstream's drag sources, moved into the
work area) drop onto a pane's tab strip, one of its four edges, or its
middle, through the same open origin a click uses; a press or key before
a slow open lands cancels the drop place. On a subagent's own page its
child's side thread is the page's own thread; the composer's pull
request chip opens beside its chat; pane ids are not reused after the
layout falls back to the default. Upstream files carry only small hooks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@orbitingflea
orbitingflea force-pushed the proto/fullscreen-panels branch from 944aab0 to 33416f9 Compare November 22, 2026 17:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant