Skip to content

NETOBSERV-2848: Add 83022 to netobserv metal jobs - #82425

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Amoghrd:netobserv-add-83022-to-metal
Aug 3, 2026
Merged

NETOBSERV-2848: Add 83022 to netobserv metal jobs#82425
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Amoghrd:netobserv-add-83022-to-metal

Conversation

@Amoghrd

@Amoghrd Amoghrd commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

OCP-83022 test requires NMState operator deployment which is only done on baremetal/vSphere envs. Adding 83022 to the metal jobs

Dependent on netobserv/netobserv-operator#2848

Summary by CodeRabbit

  • Adds NetObserv test OCP-83022 to bare-metal and vSphere-compatible metal CI jobs across nightly 4.19–5.0 configurations.
  • Extends relevant job timeouts and adds wait steps for cluster preparation.
  • Excludes the specialized test from broad NetObserv runs to avoid duplicate execution.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

NetObserv nightly job filters now include test identifier 83022. The Ginkgo skip list excludes it from broad jobs, while selected nightly-4.22 jobs gain extended timeouts and updated wait-step wiring.

Changes

NetObserv nightly test updates

Layer / File(s) Summary
Ginkgo test selection alignment
ci-operator/step-registry/netobserv/ginkgo-tests/netobserv-ginkgo-tests-commands.sh, ci-operator/config/openshift/network-observability-operator/*nightly-4.19.yaml, *nightly-4.20.yaml, *nightly-4.21.yaml, *nightly-4.22.yaml, *nightly-5.0.yaml
The specialized skip list and virtual-machine nightly job focus filters now include identifier 83022.
Nightly execution timing and wait steps
ci-operator/config/openshift/network-observability-operator/*nightly-4.22.yaml
Three nightly-4.22 jobs receive six-hour timeout extensions and updated wait test-step wiring.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • openshift/release#82411: Modifies the same nightly-4.22 configuration with related timeout and wait-step updates.

Suggested labels: jira/valid-reference

Suggested reviewers: memodi

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo titles were changed; the PR only updates CI focus/skip filters and job wiring, which are static config values.
Test Structure And Quality ✅ Passed No Ginkgo test code changed; the PR only updates CI configs and a skip-list in a shell helper, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo tests were added; the PR only changes CI focus/skip filters for existing netobserv jobs, so there’s no MicroShift compatibility issue to flag.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR only changes CI focus/skip filters for an existing test; no new Ginkgo spec or SNO-sensitive test logic was added to audit.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI job configs and a Ginkgo skip list changed; no manifests, controllers, or pod scheduling constraints were modified.
Ote Binary Stdout Contract ✅ Passed No OTE binary code changed; PR only updates CI YAML and a shell wrapper, and its stdout echos are existing job logs, not openshift-tests JSON output.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates CI focus/skip filters for existing test 83022; it doesn't add or modify Ginkgo test bodies, so no new IPv4/external-connectivity assumptions to review.
No-Weak-Crypto ✅ Passed Touched files only adjust Ginkgo filters/skip lists; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparison code appears.
Container-Privileges ✅ Passed Touched CI configs and a shell step only changed Ginkgo focus/skip filters; no privileged, hostPID/network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs ✅ Passed PASS: The changes only adjust Ginkgo focus/skip filters; no new logs, secrets, tokens, or PII are introduced. Existing password echo is unchanged.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding test 83022 to NetObserv metal jobs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Amoghrd
Amoghrd force-pushed the netobserv-add-83022-to-metal branch from c4f521e to cca29ea Compare July 24, 2026 19:07
@Amoghrd
Amoghrd force-pushed the netobserv-add-83022-to-metal branch from cca29ea to 73679ad Compare July 24, 2026 19:09
@Amoghrd Amoghrd changed the title Add 83022 to netobserv metal jobs NETOBSERV-2848: Add 83022 to netobserv metal jobs Jul 24, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@Amoghrd: This pull request references NETOBSERV-2848 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.0." or "openshift-5.0.", but it targets "netobserv-2.0" instead.

Details

In response to this:

OCP-83022 test requires NMState operator deployment which is only done on baremetal/vSphere envs. Adding 83022 to the metal jobs

Summary by CodeRabbit

  • Adds NetObserv test OCP-83022 to bare-metal and vSphere-compatible metal CI jobs across nightly 4.19–5.0 configurations.
  • Extends relevant job timeouts and adds wait steps for cluster preparation.
  • Excludes the specialized test from broad NetObserv runs to avoid duplicate execution.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Amoghrd

Amoghrd commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

/assign @memodi

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Amoghrd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-netobserv-netobserv-operator-main-e2etest netobserv/netobserv-operator presubmit Registry content changed
pull-ci-netobserv-flowlogs-pipeline-main-qe-e2e-tests netobserv/flowlogs-pipeline presubmit Registry content changed
pull-ci-netobserv-netobserv-ebpf-agent-main-qe-e2e-tests netobserv/netobserv-ebpf-agent presubmit Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.20-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt N/A periodic Ci-operator config changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-aws-ipi-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.19-netobserv-gcp-ipi-amd-f14 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.19-netobserv-vsphere-ipi-amd-f28 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt N/A periodic Ci-operator config changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.18-netobserv-azure-ipi-amd-f14 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.14-netobserv-aws-ipi-amd-f60 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-5.0-netobserv-vsphere-ipi-amd-f28 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-5.0-netobserv-azure-ipi-amd-f7 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.21-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-5.0-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt N/A periodic Ci-operator config changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.16-netobserv-aws-ipi-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-5.0-netobserv-aws-ipi-amd-f7 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.21-netobserv-aws-ipi-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.21-netobserv-vsphere-ipi-amd-f28 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-azure-ipi-amd-f7 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-vsphere-ipi-amd-f28 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.20-netobserv-vsphere-ipi-amd-f28 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.18-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f60-ipv6 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.16-netobserv-aws-ipi-amd-f28 N/A periodic Registry content changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.20-netobserv-aws-ipi-arm-f28 N/A periodic Registry content changed

A total of 39 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Amoghrd

Amoghrd commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Amoghrd Amoghrd changed the title NETOBSERV-2848: Add 83022 to netobserv metal jobs NETOBSERV-2812: Add 83022 to netobserv metal jobs Jul 27, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@Amoghrd: This pull request references NETOBSERV-2812 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.0." or "openshift-5.0.", but it targets "netobserv-2.0" instead.

Details

In response to this:

OCP-83022 test requires NMState operator deployment which is only done on baremetal/vSphere envs. Adding 83022 to the metal jobs

Summary by CodeRabbit

  • Adds NetObserv test OCP-83022 to bare-metal and vSphere-compatible metal CI jobs across nightly 4.19–5.0 configurations.
  • Extends relevant job timeouts and adds wait steps for cluster preparation.
  • Excludes the specialized test from broad NetObserv runs to avoid duplicate execution.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Amoghrd Amoghrd changed the title NETOBSERV-2812: Add 83022 to netobserv metal jobs NETOBSERV-2848: Add 83022 to netobserv metal jobs Jul 27, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@Amoghrd: This pull request references NETOBSERV-2848 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.0." or "openshift-5.0.", but it targets "netobserv-2.0" instead.

Details

In response to this:

OCP-83022 test requires NMState operator deployment which is only done on baremetal/vSphere envs. Adding 83022 to the metal jobs

Summary by CodeRabbit

  • Adds NetObserv test OCP-83022 to bare-metal and vSphere-compatible metal CI jobs across nightly 4.19–5.0 configurations.
  • Extends relevant job timeouts and adds wait steps for cluster preparation.
  • Excludes the specialized test from broad NetObserv runs to avoid duplicate execution.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Amoghrd

Amoghrd commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Amoghrd

Amoghrd commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 29, 2026
@Amoghrd

Amoghrd commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Rehearse job is passing(including 83022 test)

@Amoghrd

Amoghrd commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Amoghrd

Amoghrd commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@jotak / @jpinsonneau Could I get LGTM here?
I am just adding 83022 test to be run on baremetal env and to be skipped from normal runs.

@jotak jotak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2026
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amoghrd, jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2026
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@Amoghrd: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 123417f into openshift:main Aug 3, 2026
17 checks passed
amogh-redhat pushed a commit to amogh-redhat/release that referenced this pull request Aug 5, 2026
TimurMP pushed a commit to TimurMP/release that referenced this pull request Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants