NETOBSERV-2876: 1.12.2 testing - #82834
Conversation
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
WalkthroughAdds generated nightly CI configurations for the Network Observability Operator on OpenShift 4.14, 4.16, 4.18, 4.20, and 4.22. The configurations define images, release candidates, resource requests, backend builds, e2e images, scheduled platform tests, workflows, reporting, and metadata. ChangesNetwork Observability nightly CI
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Amoghrd The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835__nightly-4.18.yaml (1)
44-166: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winRegenerate and include Prow job metadata for this variant.
This config adds five periodic tests, and
ci-operator/jobs/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835-periodics.yamlhas the matching jobs. Runmake updatesoci-operator/config/openshift/network-observability-operator/zz_generated_metadata.yamland generated job config become the source of truth.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835__nightly-4.18.yaml` around lines 44 - 166, Run make update to regenerate the Prow metadata for the five added periodic tests, including the variant metadata and matching generated periodics job configuration. Ensure the updated generated files become the source of truth and include all five jobs.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835__nightly-4.18.yaml`:
- Around line 91-128: Add a reporter_config block to both
netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f60-ipv6 and
netobserv-metal-ds-ipi-ovn-ipv4-f60-virt, matching the existing configuration
used by the other NetObserv jobs so results are posted to `#team-qe-netobserv`.
In
`@ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835__nightly-4.20.yaml`:
- Around line 44-171: Run make update to regenerate Prow job metadata for the
five new tests in the netobserv-2835 nightly configuration. Verify the generated
periodic jobs file and its zz_generated_metadata include all newly added jobs.
---
Outside diff comments:
In
`@ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835__nightly-4.18.yaml`:
- Around line 44-166: Run make update to regenerate the Prow metadata for the
five added periodic tests, including the variant metadata and matching generated
periodics job configuration. Ensure the updated generated files become the
source of truth and include all five jobs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: de937fc4-2318-4b4b-bfe9-7f48da4bdbdb
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (5)
ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835__nightly-4.14.yamlci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835__nightly-4.16.yamlci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835__nightly-4.18.yamlci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835__nightly-4.20.yamlci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-netobserv-2835__nightly-4.22.yaml
57f034b to
b81fd35
Compare
|
/pj-rehearse periodic-ci-openshift-network-observability-operator-netobserv-2835-nightly-4.16-netobserv-aws-ipi-arm-f28 |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-network-observability-operator-netobserv-2835-nightly-4.20-netobserv-aws-ipi-arm-f28 |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
b81fd35 to
505cd1d
Compare
|
/pj-rehearse periodic-ci-openshift-network-observability-operator-netobserv-2835-nightly-4.16-netobserv-aws-ipi-amd-f28 |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-network-observability-operator-netobserv-2835-nightly-4.22-netobserv-azure-ipi-amd-f7 |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
505cd1d to
7ad36c3
Compare
openshift-ci-robot
added
the
jira/valid-reference
|
@Amoghrd: This pull request references NETOBSERV-2876 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-network-observability-operator-netobserv-2835-nightly-4.18-netobserv-vsphere-ipi-amd-f28 |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-network-observability-operator-netobserv-2835-nightly-4.14-netobserv-aws-ipi-arm-f60 |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-network-observability-operator-netobserv-2835-nightly-4.20-netobserv-azure-ipi-amd-f14 |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-network-observability-operator-netobserv-2835-nightly-4.20-netobserv-aws-ipi-arm-f28 |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@Amoghrd: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary by CodeRabbit
Adds generated OpenShift CI configurations for the Network Observability Operator nightly pipelines on OCP 4.14, 4.16, 4.18, 4.20, and 4.22.
The configurations define release candidate images, test images, backend build steps, resource requests, metadata, and scheduled NetObserv tests. The OCP 4.18, 4.20, and 4.22 pipelines add AWS, Azure, bare-metal, and vSphere test coverage.