NetObserv testing

[Amoghrd]

Summary by CodeRabbit

Extends NetObserv nightly CI job timeouts by six hours for bare-metal and vSphere environments across OpenShift 4.18, 4.20, and 4.22. Adds a wait step after cluster preparation to improve job sequencing before the main test steps run.

[Amoghrd]

/hold

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ac1cdf3b-e3ad-41a4-b7b0-4095c2d28fa0

📥 Commits

Reviewing files that changed from the base of the PR and between 2d2a11c and ebaaf6f.

📒 Files selected for processing (3)

• ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.18.yaml
• ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.20.yaml
• ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.22.yaml

🚧 Files skipped from review as they are similar to previous changes (3)

• ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.18.yaml
• ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.20.yaml
• ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.22.yaml

---

Walkthrough

Nightly network observability jobs for OpenShift 4.18, 4.20, and 4.22 now use six-hour timeouts and add wait steps after cluster preparation or before end-to-end tests.

Changes

Network observability CI jobs

Layer / File(s)

Summary

Configure job timeouts and wait steps ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.18.yaml, ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.20.yaml, ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.22.yaml

Seven bare-metal, metal OVN, and vSphere jobs set TIMEOUT: + 6 hours. They add wait after cluster preparation or before the existing end-to-end test chain.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: jotak, jpinsonneau

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the NetObserv testing configuration changes covered by the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The branch-side diff changes only three CI YAML files, adding TIMEOUT and wait entries; it adds no Ginkgo test titles or dynamic title values.
Test Structure And Quality	✅ Passed	The PR changes CI job YAML only; no Ginkgo test source, It blocks, resource setup, or cluster assertions are introduced or modified.
Microshift Test Compatibility	✅ Passed	The PR changes only three CI YAML files; it adds no Ginkgo tests or test source, so no MicroShift-incompatible API usage is introduced.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only CI YAML job timeouts and wait steps; it adds no Ginkgo e2e tests or test code that could make SNO-incompatible assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The changes are limited to CI YAML job steps that add TIMEOUT and wait references; they do not modify deployment manifests, operator code, controllers, or pod scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR diff against its base changes only three CI YAML files, adding TIMEOUT and wait steps; it adds no OTE binary or process-level stdout code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only CI YAML: timeout and wait steps. No Ginkgo test declarations, IPv4 parsing, hardcoded addresses, or external connectivity were added.
No-Weak-Crypto	✅ Passed	The PR adds only TIMEOUT and wait YAML entries in three NetObserv job files; added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto, or secret comparisons.
Container-Privileges	✅ Passed	The PR diff adds only TIMEOUT and wait entries in three CI YAML files; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, securityContext, or allowPrivilegeEscalation settings are added.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds only TIMEOUT values and existing wait references; no logging statements or sensitive literals were added. The wait step only runs a wait command.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Amoghrd
Once this PR has been reviewed and has the lgtm label, please assign jpinsonneau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/network-observability-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-vsphere-ipi-amd-f28

[openshift-merge-bot]

@Amoghrd: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-vsphere-ipi-amd-f28

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt

[openshift-merge-bot]

@Amoghrd: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

[Amoghrd]

/retest

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@Amoghrd, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't checkout base SHA 0637da6c318ee4dcd52db274513d4780d271be1a: error checking out "0637da6c318ee4dcd52db274513d4780d271be1a": exit status 128 fatal: unable to read tree (0637da6c318ee4dcd52db274513d4780d271be1a)

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@Amoghrd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6	2f11cc1	link	unknown	/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6
ci/rehearse/periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt	2f11cc1	link	unknown	/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Amoghrd]

/pj-rehearse list

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[Amoghrd]

/pj-rehearse periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.18-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f60-ipv6

[openshift-merge-bot]

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@Amoghrd: job(s): periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.18-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f60-ipv6 either don't exist or were not found to be affected, and cannot be rehearsed

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@Amoghrd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-ipv4-f28-virt	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-vsphere-ipi-amd-f28	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-network-observability-operator-release-2.0-nightly-4.22-netobserv-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.