Ipifmw - #81566
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (6)
WalkthroughThe change adds five scheduled baremetal test jobs for releases 4.21 and 4.22. It updates baremetal lab wait and post steps. It also disables ten QE test-chain references. ChangesBaremetal nightly jobs
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant NightlyScheduler
participant BaremetalWorkflow
participant QEChain
participant BaremetalLabPost
participant BaremetalLabWait
NightlyScheduler->>BaremetalWorkflow: Start scheduled baremetal job
BaremetalWorkflow->>QEChain: Run selected QE steps
BaremetalWorkflow->>BaremetalLabPost: Start post chain
BaremetalLabPost->>BaremetalLabWait: Run wait step
BaremetalLabWait->>BaremetalLabWait: Use QE base image and cluster duration
Possibly related PRs
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@sgoveas: |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-ipi-ovn-dualstack-vmedia-f7 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.sh`:
- Around line 96-98: The baremetal lab IPI install script is hardcoding an
ephemeral build05 release pull spec instead of using the injected job payload.
Update the OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE and MULTI_RELEASE_IMAGE
assignments in baremetal-lab-ipi-install-commands.sh to reference the existing
injected release image variable/value from the job configuration rather than a
fixed registry.build05.ci.openshift.org/ci-ln-v3z37h2/release:latest pull spec,
so consumers use the configured payload consistently.
In `@ci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.yaml`:
- Around line 4-6: The shared baremetal-lab-post chain currently drops failure
artifact collection by removing baremetal-lab-agent-gather and gather, which
affects every workflow that uses it. Restore those refs in
baremetal-lab-post-chain and keep baremetal-lab-wait alongside them, or if this
change is meant to be temporary, move it into a separate WIP chain instead of
modifying the shared chain.
In
`@ci-operator/step-registry/openshift/e2e/test/qe/openshift-e2e-test-qe-chain.yaml`:
- Around line 5-14: The QE chain is effectively disabled because all of its test
refs are commented out, so fix `openshift-e2e-test-qe` by restoring the intended
`ref` steps or moving this debug-only variant into a separate chain definition.
Update the chain around `openshift-e2e-test-qe` so it still includes the
documented golang/cucushift/cypress coverage, and keep the
`cucushift-installer-check-cluster-health` step plus the full test sequence
aligned with the chain name and docs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2f14ed7b-d753-477f-b3ed-379a2ba08e18
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (7)
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__multi-nightly.yamlci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.shci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.yamlci-operator/step-registry/baremetal/lab/wait/baremetal-lab-wait-ref.yamlci-operator/step-registry/openshift/e2e/test/qe/openshift-e2e-test-qe-chain.yaml
| export OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE="registry.build05.ci.openshift.org/ci-ln-v3z37h2/release:latest" | ||
| export MULTI_RELEASE_IMAGE="registry.build05.ci.openshift.org/ci-ln-v3z37h2/release:latest" | ||
|
|
There was a problem hiding this comment.
🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the file around the reported lines.
file="ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.sh"
wc -l "$file"
sed -n '1,220p' "$file"
# Find where these variables are used elsewhere in the step registry.
rg -n 'OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE|MULTI_RELEASE_IMAGE|RELEASE_IMAGE_LATEST|release:latest|ci-ln-v3z37h2' ci-operator/step-registryRepository: openshift/release
Length of output: 50374
🏁 Script executed:
#!/bin/bash
set -euo pipefail
ref="ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-ref.yaml"
cmd="ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.sh"
echo "== ref excerpt =="
sed -n '1,120p' "$ref"
echo
echo "== command excerpt =="
sed -n '88,122p' "$cmd"
echo
echo "== step usages =="
rg -n 'baremetal-lab-ipi-install' ci-operator/config ci-operator/step-registry | head -n 80Repository: openshift/release
Length of output: 7630
Use the injected release image instead of a fixed build05 pull spec. OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE and MULTI_RELEASE_IMAGE already come from release:latest; hardcoding registry.build05.ci.openshift.org/ci-ln-v3z37h2/release:latest makes every consumer depend on an ephemeral rehearsal image and bypasses the job’s configured payload.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.sh`
around lines 96 - 98, The baremetal lab IPI install script is hardcoding an
ephemeral build05 release pull spec instead of using the injected job payload.
Update the OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE and MULTI_RELEASE_IMAGE
assignments in baremetal-lab-ipi-install-commands.sh to reference the existing
injected release image variable/value from the job configuration rather than a
fixed registry.build05.ci.openshift.org/ci-ln-v3z37h2/release:latest pull spec,
so consumers use the configured payload consistently.
| # - ref: baremetal-lab-agent-gather | ||
| # - chain: gather | ||
| - ref: baremetal-lab-wait |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== file context =="
git ls-files 'ci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.yaml' \
'ci-operator/step-registry/baremetal/lab/post/*' \
'ci-operator/step-registry/**/gather*' \
'ci-operator/step-registry/**/agent-gather*'
echo
echo "== chain file =="
nl -ba ci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.yaml | sed -n '1,120p'
echo
echo "== references to baremetal-lab-post =="
rg -n --hidden --glob '!**/.git/**' 'baremetal-lab-post' ci-operator/step-registry ci-operator/config . 2>/dev/null || true
echo
echo "== references to baremetal-lab-agent-gather and gather chain =="
rg -n --hidden --glob '!**/.git/**' 'baremetal-lab-agent-gather|chain:\s*gather\b|\bgather\b' ci-operator/step-registry/baremetal ci-operator/config 2>/dev/null || trueRepository: openshift/release
Length of output: 23419
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== baremetal-lab-post-chain.yaml =="
cat -n ci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.yaml | sed -n '1,80p'
echo
echo "== baremetal-lab-post chain metadata =="
cat -n ci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.metadata.json | sed -n '1,80p'
echo
echo "== direct references to baremetal-lab-post chain =="
rg -n --hidden --glob '!**/.git/**' 'baremetal-lab-post' ci-operator/step-registry ci-operator/config | sed -n '1,200p'
echo
echo "== direct references to baremetal-lab-agent-gather in baremetal-lab context =="
rg -n --hidden --glob '!**/.git/**' 'baremetal-lab-agent-gather|chain:\s*gather\b' ci-operator/step-registry/baremetal ci-operator/config | sed -n '1,200p'Repository: openshift/release
Length of output: 33973
Keep baremetal-lab-post gathering failure artifacts ci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.yaml:4-6
Removing baremetal-lab-agent-gather and gather from this shared chain drops must-gather/agent logs for every workflow that uses baremetal-lab-post, making failure triage much harder. If this is temporary, split it into a separate WIP chain instead of changing the shared one.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.yaml`
around lines 4 - 6, The shared baremetal-lab-post chain currently drops failure
artifact collection by removing baremetal-lab-agent-gather and gather, which
affects every workflow that uses it. Restore those refs in
baremetal-lab-post-chain and keep baremetal-lab-wait alongside them, or if this
change is meant to be temporary, move it into a separate WIP chain instead of
modifying the shared chain.
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@sgoveas, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-pxe-multi-arch-day2-amd-f14 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-vmedia-amd-f7 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-multi-nightly-metal-ipi-ovn-ipv4-vmedia-amd-f7 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
0bf5940 to
f98bc29
Compare
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@sgoveas: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-metal-ipi-ovn-ipv4-vmedia-bmaas-day2-amd-f14 |
|
@sgoveas: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Add ipi primary ipv6 and dualstack primary v6
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[REHEARSALNOTIFIER]
A total of 2395 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
1 participant
Summary by CodeRabbit
baremetal-lab-agent-gatherpost step and increases the default bare-metal wait duration to 72 hours.baremetal-qe-base:latest.